chore!: remove replacing values in configuration marked by 'replace' suffix #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kasia-kujawa
force-pushed
the
kk-revert-1721
branch
from
512986f
to
ed9ece8
Compare
kasia-kujawa
force-pushed
the
kk-revert-1721
branch
from
ed9ece8
to
f37b99a
Compare
kasia-kujawa
force-pushed
the
kk-revert-1721
branch
4 times, most recently
from
d5d1a27
to
f37b99a
Compare
sumo-drosiek
approved these changes
Nov 18, 2022
I need to add at least information to migration doc that the mechanism with replacing some configuration values with 'replace' suffix was removed. related change in update-collection-v3: SumoLogic/sumologic-kubernetes-tools#382 |
kasia-kujawa
force-pushed
the
kk-revert-1721
branch
from
f37b99a
to
32a635c
Compare
kasia-kujawa
added a commit
to SumoLogic/sumologic-kubernetes-tools
that referenced
this pull request
Nov 22, 2022
…ace' suffix in configuration for otelcol and otelagent related to SumoLogic/sumologic-kubernetes-collection#2615
kasia-kujawa
added a commit
to SumoLogic/sumologic-kubernetes-tools
that referenced
this pull request
Nov 22, 2022
…ace' suffix in configuration for otelcol and otelagent related to SumoLogic/sumologic-kubernetes-collection#2615
kasia-kujawa
force-pushed
the
kk-revert-1721
branch
from
32a635c
to
4892a55
Compare
kasia-kujawa
changed the title
kasia-kujawa
force-pushed
the
kk-revert-1721
branch
3 times, most recently
from
98dee38
to
f9daff2
Compare
kasia-kujawa
added a commit
to SumoLogic/sumologic-kubernetes-tools
that referenced
this pull request
Nov 23, 2022
…ace' suffix in configuration for otelcol and otelagent related to SumoLogic/sumologic-kubernetes-collection#2615
kasia-kujawa
force-pushed
the
kk-revert-1721
branch
from
f9daff2
to
2e7d283
Compare
kasia-kujawa
added a commit
to SumoLogic/sumologic-kubernetes-tools
that referenced
this pull request
Nov 23, 2022
…ace' suffix in configuration for otelcol and otelagent related to SumoLogic/sumologic-kubernetes-collection#2615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: remove replacing values in configuration marked by 'replace' suffix
make values in configuration for otelcol dependended on otelcol parameters in values.yaml
removes "otelcol.k8s.cluster.name" which was added in #1721 and it is no longer in use
this pull request reverts changes introduced in #1721
related to #1729
Generated templates have been compared using output of
helm template . -f values.yaml -f values_custom.yamlwherevalues_custom.yamlhad following form:related change in
update-collection-v3: SumoLogic/sumologic-kubernetes-tools#382