Improved property descriptions #4451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved descriptions to address Remi's slack question: "How is calculated the distance at which diffusion profile stops having an effect in HDRP ? And what does it depends on ?"
|
It appears that you made a non-draft PR! |
| | **Max Radius** | An informative helper value that displays the effective maximum radius (in millimeters) of the effect you define in Scattering Distance. You can not change this value directly. | | ||
| | **Index of Refraction** | Use the slider to set the refractive behavior of the Material. Larger values increase the intensity of specular reflection. For example, the index of refraction of skin is about 1.4. For more example values for the index of refraction of different materials, see Pixel and Poly’s [list of indexes of refraction values](https://pixelandpoly.com/ior.html). | | ||
| | **Scattering Distance** | Use the color picker (circle icon) to define how far each light channel in the Diffusion Profile travels below the surface:<br/><br/>**R**: Defines how far the red light channel travels below the surface.<br/>**G**: Controls how far the green light channel travels below the surface.<br/>**B**: Controls how far the blue light channel travels below the surface.<br/><br/>The overall color affects the Transmission tint. | | ||
| | **Max Radius** | The maximum radius of the effect you define in **Scattering Distance**. The size of this value depends on the world scale. For example, when the world scale is 1, this value is in meters. When the world scale is 0.01, this value is in millimeters.<br/><br/>When the size of this radius is smaller than a pixel on the screen, HDRP does not apply Subsurface Scattering. | |
There was a problem hiding this comment.
For example, when the world scale is 1, this value is in meters. When the world scale is 0.01, this value is in millimeters.
Shouldn't this be 1 => meters, 0.001 => millimeters ? (10^-3 instead of 10^-2)
There was a problem hiding this comment.
Good spot, thanks!
0.01 > 0.001
sebastienlagarde
approved these changes
May 11, 2021
sebastienlagarde
pushed a commit
that referenced
this pull request
May 25, 2021
* Improved property descriptions Improved descriptions to address Remi's slack question: "How is calculated the distance at which diffusion profile stops having an effect in HDRP ? And what does it depends on ?" * Fixed scale 0.01 > 0.001
sebastienlagarde
pushed a commit
that referenced
this pull request
Jun 14, 2021
* Improved property descriptions Improved descriptions to address Remi's slack question: "How is calculated the distance at which diffusion profile stops having an effect in HDRP ? And what does it depends on ?" * Fixed scale 0.01 > 0.001
sebastienlagarde
added a commit
that referenced
this pull request
Jun 16, 2021
* Opt-out of builtin auto baking of ambient/reflection probe. #4324 * Fix Unifed Shader Precision Model in SRP shaders by supporting half precision on desktop #4349 * Improved property descriptions (#4451) * Improved property descriptions Improved descriptions to address Remi's slack question: "How is calculated the distance at which diffusion profile stops having an effect in HDRP ? And what does it depends on ?" * Fixed scale 0.01 > 0.001 * [HDRP] Merge Hd/bugfix #4731 * Update CHANGELOG.md * [HDRP] Merge Hd/bugfix #4713 * fix compil issue * Update SubsurfaceScatteringManagerRT.cs * Update 902_Materials_SG_Variants_Lit.png Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: NetteVI <nette.vi@gmail.com> Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com>
sebastienlagarde
added a commit
that referenced
this pull request
Jun 16, 2021
* Opt-out of builtin auto baking of ambient/reflection probe. #4324 * Fix Unifed Shader Precision Model in SRP shaders by supporting half precision on desktop #4349 * Improved property descriptions (#4451) * Improved property descriptions Improved descriptions to address Remi's slack question: "How is calculated the distance at which diffusion profile stops having an effect in HDRP ? And what does it depends on ?" * Fixed scale 0.01 > 0.001 * [HDRP] Merge Hd/bugfix #4731 * Update CHANGELOG.md * [HDRP] Merge Hd/bugfix #4713 * fix compil issue * Update SubsurfaceScatteringManagerRT.cs * Update 902_Materials_SG_Variants_Lit.png * Align LitTessellation to Lit and LayereLitTessellation to LayeredLit. + make the former fallback on the latter in R #4661 * Merge Hd/bugfix #4825 * Merge Hd/bugfix #4830 * fix Dx12 screenshots * Update CHANGELOG.md * Update CHANGELOG.md * add exception for the renaming of LightLayersDefault * Disable 2008 DXR test * Update 1000_RaytracingQualityKeyword_Indirect.png.meta Co-authored-by: JulienIgnace-Unity <julien@unity3d.com> Co-authored-by: NetteVI <nette.vi@gmail.com> Co-authored-by: Vic Cooper <63712500+Vic-Cooper@users.noreply.github.com> Co-authored-by: FrancescoC-unity <43168857+FrancescoC-unity@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved descriptions to address Remi's slack question: "How is calculated the distance at which diffusion profile stops having an effect in HDRP? And what does it depends on?"
It would be helpful to backport this to 7.x for consistency.