Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable loading lookups by default in CompactionTask #16420

Merged
merged 17 commits into from
May 15, 2024
Merged

Disable loading lookups by default in CompactionTask #16420

merged 17 commits into from
May 15, 2024

Commits on May 9, 2024

  1. Disable loading lookups by default in CompactionTask

    @Akshat-Jain
    Akshat-Jain committed May 9, 2024
    Configuration menu
    Copy the full SHA
    2f6066f View commit details
    Browse the repository at this point in the history

  2. Improve jacoco branch coverage

    @Akshat-Jain
    Akshat-Jain committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d22ee89 View commit details
    Browse the repository at this point in the history

  3. Address review comments

    @Akshat-Jain
    Akshat-Jain committed May 9, 2024
    Configuration menu
    Copy the full SHA
    6c5420e View commit details
    Browse the repository at this point in the history

  4. Fix ClientCompactionTaskQuerySerdeTest

    @Akshat-Jain
    Akshat-Jain committed May 9, 2024
    Configuration menu
    Copy the full SHA
    149721d View commit details
    Browse the repository at this point in the history

  5. Use assertArrayEquals instead of assertEquals

    @Akshat-Jain
    Akshat-Jain committed May 9, 2024
    Configuration menu
    Copy the full SHA
    170e59e View commit details
    Browse the repository at this point in the history

  6. Address review comments

    @Akshat-Jain
    Akshat-Jain committed May 9, 2024
    Configuration menu
    Copy the full SHA
    c0e9a90 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. Address review comments

    @Akshat-Jain
    Akshat-Jain committed May 10, 2024
    Configuration menu
    Copy the full SHA
    948eb01 View commit details
    Browse the repository at this point in the history

  2. Remove parameterization from test

    @Akshat-Jain
    Akshat-Jain committed May 10, 2024
    Configuration menu
    Copy the full SHA
    49193cd View commit details
    Browse the repository at this point in the history

  3. Revert the change in junit import

    @Akshat-Jain
    Akshat-Jain committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4907acf View commit details
    Browse the repository at this point in the history

  4. Ensure backward compatibility by loading all lookups if transformSpec… 

    … is present, unless overridden by context
    @Akshat-Jain
    Akshat-Jain committed May 10, 2024
    Configuration menu
    Copy the full SHA
    b39ce25 View commit details
    Browse the repository at this point in the history

  5. Remove CompactionTask#getLookupLoadingSpec as it's redundant

    @Akshat-Jain
    Akshat-Jain committed May 10, 2024
    Configuration menu
    Copy the full SHA
    02acf83 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2024

  1. Address review comments

    @Akshat-Jain
    Akshat-Jain committed May 11, 2024
    Configuration menu
    Copy the full SHA
    0f08126 View commit details
    Browse the repository at this point in the history

  2. Address review comment

    @Akshat-Jain
    Akshat-Jain committed May 11, 2024
    Configuration menu
    Copy the full SHA
    ac2d836 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. Address review comments

    @Akshat-Jain
    Akshat-Jain committed May 13, 2024
    Configuration menu
    Copy the full SHA
    262f6a1 View commit details
    Browse the repository at this point in the history

  2. Make DruidException final in the tests

    @Akshat-Jain
    Akshat-Jain committed May 13, 2024
    Configuration menu
    Copy the full SHA
    0f6b09d View commit details
    Browse the repository at this point in the history

  3. Use StringUtils.format() instead of String.format()

    @Akshat-Jain
    Akshat-Jain committed May 13, 2024
    Configuration menu
    Copy the full SHA
    3f7de75 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Address review comment

    @Akshat-Jain
    Akshat-Jain committed May 14, 2024
    Configuration menu
    Copy the full SHA
    e6e92a4 View commit details
    Browse the repository at this point in the history