Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable loading lookups by default in CompactionTask #16420

Merged
merged 17 commits into from
May 15, 2024
Merged

Disable loading lookups by default in CompactionTask #16420

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2f6066f
Disable loading lookups by default in CompactionTask
Akshat-Jain May 3, 2024
d22ee89
Improve jacoco branch coverage
Akshat-Jain May 9, 2024
6c5420e
Address review comments
Akshat-Jain May 9, 2024
149721d
Fix ClientCompactionTaskQuerySerdeTest
Akshat-Jain May 9, 2024
170e59e
Use assertArrayEquals instead of assertEquals
Akshat-Jain May 9, 2024
c0e9a90
Address review comments
Akshat-Jain May 9, 2024
948eb01
Address review comments
Akshat-Jain May 10, 2024
49193cd
Remove parameterization from test
Akshat-Jain May 10, 2024
4907acf
Revert the change in junit import
Akshat-Jain May 10, 2024
b39ce25
Ensure backward compatibility by loading all lookups if transformSpec…
Akshat-Jain May 10, 2024
02acf83
Remove CompactionTask#getLookupLoadingSpec as it's redundant
Akshat-Jain May 10, 2024
0f08126
Address review comments
Akshat-Jain May 11, 2024
ac2d836
Address review comment
Akshat-Jain May 11, 2024
262f6a1
Address review comments
Akshat-Jain May 13, 2024
0f6b09d
Make DruidException final in the tests
Akshat-Jain May 13, 2024
3f7de75
Use StringUtils.format() instead of String.format()
Akshat-Jain May 13, 2024
e6e92a4
Address review comment
Akshat-Jain May 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review comments
  • Loading branch information
@Akshat-Jain
Akshat-Jain committed May 10, 2024
commit 948eb01e8590967dfd3e70876a51fbc429790957
18 changes: 7 additions & 11 deletions ...c/test/java/org/apache/druid/indexing/common/task/ClientCompactionTaskQuerySerdeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,7 @@ public void testCompactionTaskToClientCompactionTaskQuery() throws IOException
.transformSpec(new ClientCompactionTaskTransformSpec(new SelectorDimFilter("dim1", "foo", null)))
.build();

Map<String, Object> expectedContext = new HashMap<>();
final ClientCompactionTaskQuery expected = new ClientCompactionTaskQuery(
task.getId(),
"datasource",
Expand Down Expand Up @@ -354,22 +355,17 @@ public void testCompactionTaskToClientCompactionTaskQuery() throws IOException
new ClientCompactionTaskDimensionsSpec(DimensionsSpec.getDefaultSchemas(ImmutableList.of("ts", "dim"))),
new AggregatorFactory[] {new CountAggregatorFactory("cnt")},
new ClientCompactionTaskTransformSpec(new SelectorDimFilter("dim1", "foo", null)),
new HashMap<>()
expectedContext
);

final byte[] json = mapper.writeValueAsBytes(task);
final ClientCompactionTaskQuery actual = (ClientCompactionTaskQuery) mapper.readValue(json, ClientTaskQuery.class);

Assert.assertEquals(expected.getDataSource(), actual.getDataSource());
Assert.assertEquals(expected.getId(), actual.getId());
Assert.assertEquals(expected.getType(), actual.getType());
Assert.assertEquals(expected.getGranularitySpec(), actual.getGranularitySpec());
Assert.assertEquals(expected.getDimensionsSpec(), actual.getDimensionsSpec());
Assert.assertEquals(expected.getIoConfig(), actual.getIoConfig());
Assert.assertEquals(expected.getTransformSpec(), actual.getTransformSpec());
Assert.assertArrayEquals(expected.getMetricsSpec(), actual.getMetricsSpec());
Assert.assertEquals(expected.getTuningConfig(), actual.getTuningConfig());
Assert.assertEquals(ImmutableMap.of(LookupLoadingSpec.CTX_LOOKUP_LOADING_MODE, LookupLoadingSpec.Mode.NONE.toString()), actual.getContext());
// Verify that CompactionTask has added new parameters into the context
Assert.assertNotEquals(expected, actual);

expectedContext.put(LookupLoadingSpec.CTX_LOOKUP_LOADING_MODE, LookupLoadingSpec.Mode.NONE.toString());
Assert.assertEquals(expected, actual);
}

private static ObjectMapper setupInjectablesInObjectMapper(ObjectMapper objectMapper)
Expand Down
Loading