Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable loading lookups by default in CompactionTask #16420

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve jacoco branch coverage
  • Loading branch information
Akshat-Jain committed May 9, 2024
commit d22ee896f0ca5a5d66532b932c45c70364722cdc
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,7 @@ public void testLoadingOnlyRequiredLookupsWithNullList()
public void testGetLookupLoadingSpecFromContext(Map<String, Object> context, LookupLoadingSpec defaultSpec, LookupLoadingSpec expectedSpec)
Akshat-Jain marked this conversation as resolved.
Show resolved Hide resolved
{
LookupLoadingSpec specFromContext = LookupLoadingSpec.getSpecFromContext(context, defaultSpec);
Assert.assertEquals(expectedSpec.getMode(), specFromContext.getMode());
Assert.assertEquals(expectedSpec.getLookupsToLoad(), specFromContext.getLookupsToLoad());
Assert.assertEquals(expectedSpec, specFromContext);
}

public static Collection<Object[]> provideParamsForTestGetSpecFromContext()
Expand Down Expand Up @@ -119,6 +118,12 @@ public static Collection<Object[]> provideParamsForTestGetSpecFromContext()
contextWithModeNone,
LookupLoadingSpec.ALL,
LookupLoadingSpec.NONE
},
// Default spec is returned in the case of context=null.
{
null,
LookupLoadingSpec.NONE,
LookupLoadingSpec.NONE
}
};

Expand Down