Runfiles Tests are failing on remote execution

[xingao267]

A lot of tests are failing on RBE when I tested with #111 where I added the Buildkite config to test against RBE. You can find the set of tests that are failing in the PR (https://github.com/bazelbuild/rules_rust/pull/111/files) where I have to skip them.

We previously tested rules_rust repo at commit ef77316 internally and this set of test targets pass on RBE:

-- @examples//... -@examples//hello_runfiles:hello_runfiles_test

It's likely there is some regression between ef77316 and 1944c8a

[acmcarther]

I missed this codegen-backends directory when I changed the toolchain fetching logic.

I'm putting together a fix now in https://github.com/bazelbuild/rules_rust/compare/acm-fix-remote-exec.

---

EDIT: That PR didn't address one of the failures. Details copied from that PR:

CI logs from commit 2 of this PR:

Runfiles test stdout:
https://buildkite.com/bazel/rules-rust-rustlang/builds/149#166b2f90-cd68-40d5-9a63-88dbd0cc1215**
Log message from test failure:
https://storage.googleapis.com/bazel-buildkite-artifacts/166b2f90-cd68-40d5-9a63-88dbd0cc1215/xamples/hello_runfiles/hello_runfiles_test/attempt_1.log

Panic site:

rules_rust/examples/hello_runfiles/src/lib.rs

Line 36 in db14152

File::open(runfiles.join("examples/hello_runfiles/data/sample.txt")).unwrap()

rules_rust/examples/hello_runfiles/src/lib.rs

Lines 5 to 17 in db14152

	pub fn get_runfiles_dir() -> io::Result<PathBuf> {
	let mut path = std::env::current_exe()?;
	if cfg!(target_os = "macos") {
	path.pop();
	} else {
	let mut name = path.file_name().unwrap().to_owned();
	name.push(".runfiles");
	path.pop();
	path.push(name);
	}
	Ok(path)

Symptom is test is trying to load the runfile but not finding it. Some historical discussion on runfiles here: #66, describing some inconsistency in treatment among OSes and languages.

If nothing else, some filesystem exploration within the test would probably help figure out where they're being routed to.

[mfarrugi]

#122 skipped the (newly added / fixed) doc tests as well, I don't have any visibility into the test failures though.

[xingao267]

@mfarrugi Can you access test links like https://source.cloud.google.com/results/invocations/4b0d4425-d14f-4baa-b248-f36463b9d08b/targets?

[mfarrugi]

Yes, those links are visible

…

On Wed, Aug 29, 2018 at 13:56 Xin ***@***.***> wrote: @mfarrugi <https://github.com/mfarrugi> Can you access test links like https://source.cloud.google.com/results/invocations/4b0d4425-d14f-4baa-b248-f36463b9d08b/targets ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#112 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACLjeLmD7UmbFhFJq4AXi8hk5H58ZVT_ks5uVtXWgaJpZM4V0xkf> .