Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI config to test on RBE. #111

Merged
merged 2 commits into from
Aug 8, 2018
Merged

Add CI config to test on RBE. #111

merged 2 commits into from
Aug 8, 2018

Conversation

xingao267
Copy link
Member

No description provided.

@acmcarther
Copy link
Collaborator

For the record: RBE = "Remote Build Execution"

Change looks good to me % failing build

https://buildkite.com/bazel/rules-rust-rustlang/builds/146#0e40cc59-e453-42d4-ba10-bbb428f9a46d
I can't tell from the failures if this is a rules_rust issue, or an issue with RBE itself. If this is an issue for rules_rust, I can help you work it out.

Also use latest release of bazel-toolchains.
@xingao267
Copy link
Member Author

It looks like all these tests are failing with "error: failed to find a codegen-backends folder in the sysroot candidates:".

Internally, we previously test with rules_rust@commit:ef77316503f1ad88c348d9cbc03bf60dbad49317, and these targets are passing fine on RBE:

-- @examples//... -@examples//hello_runfiles:hello_runfiles_test

It seems that there is some regression between ef77316 and head, that causes more tests broken on RBE.

@xingao267
Copy link
Member Author

I've skipped the failing tests in the CI setup, and opened issue #112. We can still setup RBE tests with whatever tests that are currently passing now.

@acmcarther
Copy link
Collaborator

My bad, I missed this in my toolchain repository refactoring.

I've got a prospective fix here https://github.com/bazelbuild/rules_rust/compare/acm-fix-remote-exec, now waiting on results from CI.

PR here LGTM.

@acmcarther acmcarther merged commit db14152 into bazelbuild:master Aug 8, 2018
@xingao267 xingao267 deleted the ci branch August 9, 2018 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants