Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RBE by including codegen-backends from rustc/ #113

Merged
merged 4 commits into from
Aug 9, 2018

Conversation

acmcarther
Copy link
Collaborator

@acmcarther acmcarther commented Aug 8, 2018

Partially fixes some tests disabled in #111

Resolves (partially) #112 EXCEPT for runfiles.

@xingao267, @mfarrugi

EDIT:
I have to say, this build caching is totally amazing:

See build results latest commit. It didn't have to run any of the tests since the tests from the last commit were still valid as you would expect under local execution.

@xingao267
Copy link
Member

The change looks good to me.

Thanks! Happy you like it!

@mfarrugi
Copy link
Collaborator

mfarrugi commented Aug 9, 2018

Lgtm, any idea what's up with the runfiles test?

@acmcarther
Copy link
Collaborator Author

acmcarther commented Aug 9, 2018

Not sure yet:

CI logs from commit 2 of this PR:

Runfiles test stdout:
https://buildkite.com/bazel/rules-rust-rustlang/builds/149#166b2f90-cd68-40d5-9a63-88dbd0cc1215**
Log message from test failure:
https://storage.googleapis.com/bazel-buildkite-artifacts/166b2f90-cd68-40d5-9a63-88dbd0cc1215/xamples/hello_runfiles/hello_runfiles_test/attempt_1.log

Panic site:

File::open(runfiles.join("examples/hello_runfiles/data/sample.txt")).unwrap()

pub fn get_runfiles_dir() -> io::Result<PathBuf> {
let mut path = std::env::current_exe()?;
if cfg!(target_os = "macos") {
path.pop();
} else {
let mut name = path.file_name().unwrap().to_owned();
name.push(".runfiles");
path.pop();
path.push(name);
}
Ok(path)

Symptom is test is trying to load the runfile but not finding it. Some historical discussion on runfiles here: #66, describing some inconsistency in treatment among OSes and languages.

If nothing else, some filesystem exploration within the test would probably help figure out where they're being routed to.

@acmcarther acmcarther merged commit 4bd8ed3 into master Aug 9, 2018
@acmcarther acmcarther deleted the acm-fix-remote-exec branch August 9, 2018 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants