Fix log_feature_error formatting

bevyengine · Oct 27, 2023 · ea4ab77 · ea4ab77
1 parent a6d6baf
commit ea4ab77
Showing 1 changed file with 8 additions and 11 deletions.
diff --git a/crates/bevy_core_pipeline/src/tonemapping/mod.rs b/crates/bevy_core_pipeline/src/tonemapping/mod.rs
@@ -182,18 +182,15 @@ impl Tonemapping {
             Self::BlenderFilmic => "TONEMAP_METHOD_BLENDER_FILMIC",
         }
     }
-    #[cfg(feature = "tonemapping_luts")]
-    pub const fn log_feature_error(self) {}
-
-    #[cfg(not(feature = "tonemapping_luts"))]
-    pub const fn log_feature_error(self) {
-        let error_message = || {
-            format!("{self:?} tonemapping requires the `tonemapping_luts` feature.
-                    Either enable the `tonemapping_luts` feature for bevy in `Cargo.toml` (recommended),
-                    or use a different `Tonemapping` method in your `Camera2dBundle`/`Camera3dBundle`.")
-        };
+
+    pub fn log_feature_error(self) {
+        #[cfg(not(feature = "tonemapping_luts"))]
         if matches!(self, Self::AgX | Self::TonyMcMapface | Self::BlenderFilmic) {
-            bevy_log::error!(error_message());
+            bevy_log::error!(
+                "{self:?} tonemapping requires the `tonemapping_luts` feature. Either enable the \
+                `tonemapping_luts` feature for bevy in `Cargo.toml` (recommended), or use a \
+                different `Tonemapping` method in your `Camera2dBundle`/`Camera3dBundle`."
+            );
         }
     }
 }