Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Fresnel for Ortho Projections #2369

Closed
aevyrie opened this issue Jun 21, 2021 · 0 comments
Closed

Incorrect Fresnel for Ortho Projections #2369

aevyrie opened this issue Jun 21, 2021 · 0 comments
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior

Comments

@aevyrie
Copy link
Member

aevyrie commented Jun 21, 2021

Bevy version

Bevy main

Operating system & version

Win10

What you did

Run the current pbr example

What you expected to happen

Fresnel for ortho camera should be a symmetric halo.

What actually happened

Fresnel "points" to the center of the screen

See fresnel highlights in this screenshot from discord:
image

image

Additional information

See this Unity bug report for the same shader bug:
https://forum.unity.com/threads/fresnel-effect-does-not-work-with-orthographic-cameras.807240/
image
@aevyrie aevyrie added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Jun 21, 2021
@aevyrie aevyrie mentioned this issue Jun 21, 2021
Closed
@NathanSWard NathanSWard added A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels Jun 21, 2021
@bors bors bot closed this as completed in 46cae59 Jul 1, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this issue Jul 27, 2021
@aevyrie @ostwilkens
Fix view vector in pbr frag to work in ortho (bevyengine#2370)
bc1f4a1 
# Objective

Fixes bevyengine#2369

## Solution

Use the view forward direction for all frags when using ortho view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Fix view vector in pbr frag to work in ortho aevyrie/bevy
2 participants
@aevyrie @NathanSWard