Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rust-version to the Cargo.toml files #2998

Closed
bjorn3 opened this issue Oct 21, 2021 · 3 comments
Closed

Add rust-version to the Cargo.toml files #2998

bjorn3 opened this issue Oct 21, 2021 · 3 comments
Labels
C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@bjorn3
Copy link
Contributor

bjorn3 commented Oct 21, 2021

What problem does this solve or what need does it fill?

This ensures that you will get an error from cargo if your rustc is too old instead of having an error from rustc when compiling a crate that needs a newer rustc version. The rustc error doesn't explain that updating rustc will fix the error.

What solution would you like?

Add

rust-version = "1.56"

or whichever version of rustc we require in the Cargo.toml of all bevy crates.

What alternative(s) have you considered?

Other solutions to solve and/or work around the problem presented.

Additional context

This was stabilized in rust 1.56.0 today. https://blog.rust-lang.org/2021/10/21/Rust-1.56.0.html#cargo-rust-version
@bjorn3 bjorn3 added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Oct 21, 2021
@TheRawMeatball TheRawMeatball removed the S-Needs-Triage This issue needs to be labelled label Oct 21, 2021
@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy and removed C-Feature A new feature, making something new possible labels Oct 21, 2021
@Ixentus Ixentus mentioned this issue Oct 21, 2021
Closed
@mockersf
Copy link
Member

We should also add a CI job with the specified Rust version

@Octorine Octorine mentioned this issue Oct 23, 2021
Closed
@mnmaita
Copy link
Member

mnmaita commented Apr 10, 2022

Is this one closeable? I see an update to edition 2021 but I'm not sure if the need for rust-version persists.

@JayPavlina
Copy link
Contributor

I think good-first-issue tag should be removed, because according to this comment, a CI job is also required. IMO this issue seems to be stale though, so either the description should be updated, or it should be closed.

@mockersf mockersf mentioned this issue Dec 5, 2022
Closed
@bors bors bot closed this as completed in 7df680b Jan 9, 2023
james7132 pushed a commit to james7132/bevy that referenced this issue Jan 21, 2023
@mockersf @james7132
add rust-version for MSRV and CI job to check (bevyengine#6852)
1ad542a 
# Objective

- Fixes bevyengine#6777, fixes bevyengine#2998, replaces bevyengine#5518
- Help avoid confusing error message when using an older version of Rust

## Solution

- Add the `rust-version` field to `Cargo.toml`
- Add a CI job checking the MSRV
- Add the job to bors
alradish pushed a commit to alradish/bevy that referenced this issue Jan 22, 2023
@mockersf @alradish
add rust-version for MSRV and CI job to check (bevyengine#6852)
aef08ca 
# Objective

- Fixes bevyengine#6777, fixes bevyengine#2998, replaces bevyengine#5518
- Help avoid confusing error message when using an older version of Rust

## Solution

- Add the `rust-version` field to `Cargo.toml`
- Add a CI job checking the MSRV
- Add the job to bors
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@mockersf @ItsDoot
add rust-version for MSRV and CI job to check (bevyengine#6852)
5207c56 
# Objective

- Fixes bevyengine#6777, fixes bevyengine#2998, replaces bevyengine#5518
- Help avoid confusing error message when using an older version of Rust

## Solution

- Add the `rust-version` field to `Cargo.toml`
- Add a CI job checking the MSRV
- Add the job to bors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - add rust-version for MSRV and CI job to check mockersf/bevy
6 participants
@alice-i-cecile @TheRawMeatball @mockersf @JayPavlina @bjorn3 @mnmaita