Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new enum default method throughout code base #5153

Closed
alice-i-cecile opened this issue Jun 30, 2022 · 0 comments
Closed

Use new enum default method throughout code base #5153

alice-i-cecile opened this issue Jun 30, 2022 · 0 comments
Labels
C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@alice-i-cecile
Copy link
Member

We can now use #[derive(Default)] on enum types!

This is clearer and more idiomatic, as it puts the default values directly on the struct definition.

We should migrate to this pattern throughout the code base; search for impl Default for to find candidates.
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Code-Quality A section of code that is hard to understand or change labels Jun 30, 2022
@rparrett rparrett mentioned this issue Jun 30, 2022
Closed
@bors bors bot closed this as completed in 5e17569 Jul 1, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this issue Aug 8, 2022
@rparrett @inodentry
Derive default for enums where possible (bevyengine#5158)
2c6c0eb 
# Objective

Fixes bevyengine#5153

## Solution

Search for all enums and manually check if they have default impls that can use this new derive.

By my reckoning:

| enum | num |
|-|-|
| total | 159 |
| has default impl | 29 |
| default is unit variant | 23 |
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 28, 2022
@rparrett @james7132
Derive default for enums where possible (bevyengine#5158)
5cccd1a 
# Objective

Fixes bevyengine#5153

## Solution

Search for all enums and manually check if they have default impls that can use this new derive.

By my reckoning:

| enum | num |
|-|-|
| total | 159 |
| has default impl | 29 |
| default is unit variant | 23 |
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@rparrett @ItsDoot
Derive default for enums where possible (bevyengine#5158)
a34003e 
# Objective

Fixes bevyengine#5153

## Solution

Search for all enums and manually check if they have default impls that can use this new derive.

By my reckoning:

| enum | num |
|-|-|
| total | 159 |
| has default impl | 29 |
| default is unit variant | 23 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Merged by Bors] - Derive default for enums where possible rparrett/bevy
1 participant
@alice-i-cecile