Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color's Add and AddAssign impls add RGBA values to HSLA #5543

Closed
Gyrobifastigium opened this issue Aug 1, 2022 · 0 comments
Closed

Color's Add and AddAssign impls add RGBA values to HSLA #5543

Gyrobifastigium opened this issue Aug 1, 2022 · 0 comments
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@Gyrobifastigium
Copy link

bevy/crates/bevy_render/src/color/mod.rs

Line 662 in f3b5bf0

let rhs = rhs.as_linear_rgba_f32();

bevy/crates/bevy_render/src/color/mod.rs

Line 711 in f3b5bf0

let rhs = rhs.as_linear_rgba_f32();

These lines should probably be let rhs = rhs.as_hsla_f32() instead.
@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen D-Trivial Nice and easy! A great choice to get started with Bevy labels Aug 1, 2022
@vertesians vertesians mentioned this issue Aug 1, 2022
Closed
@bors bors bot closed this as completed in 56fc1df Aug 17, 2022
inodentry pushed a commit to BroovyJammy/bevy that referenced this issue Aug 19, 2022
@vertesians @inodentry
Correctly use as_hsla_f32 in Add<Color> and AddAssign<Color>, fixes b…
2b09a06 
…evyengine#5543 (bevyengine#5546)

Probably a copy-paste error, but `Add<Color>` and `AddAssign<Color>` should use `rhs.as_hlsa_f32()` instead of `rhs.as_linear_rgba_f32()` when the LHS is a `Color::Hsla`. Fixes bevyengine#5543.



Co-authored-by: Verte <105466627+vertesians@users.noreply.github.com>
maccesch pushed a commit to Synphonyte/bevy that referenced this issue Sep 28, 2022
@vertesians @maccesch
Correctly use as_hsla_f32 in Add<Color> and AddAssign<Color>, fixes b…
c226d57 
…evyengine#5543 (bevyengine#5546)

Probably a copy-paste error, but `Add<Color>` and `AddAssign<Color>` should use `rhs.as_hlsa_f32()` instead of `rhs.as_linear_rgba_f32()` when the LHS is a `Color::Hsla`. Fixes bevyengine#5543.



Co-authored-by: Verte <105466627+vertesians@users.noreply.github.com>
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 28, 2022
@vertesians @james7132
Correctly use as_hsla_f32 in Add<Color> and AddAssign<Color>, fixes b…
5c5337c 
…evyengine#5543 (bevyengine#5546)

Probably a copy-paste error, but `Add<Color>` and `AddAssign<Color>` should use `rhs.as_hlsa_f32()` instead of `rhs.as_linear_rgba_f32()` when the LHS is a `Color::Hsla`. Fixes bevyengine#5543.



Co-authored-by: Verte <105466627+vertesians@users.noreply.github.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
@vertesians @ItsDoot
Correctly use as_hsla_f32 in Add<Color> and AddAssign<Color>, fixes b…
ce01546 
…evyengine#5543 (bevyengine#5546)

Probably a copy-paste error, but `Add<Color>` and `AddAssign<Color>` should use `rhs.as_hlsa_f32()` instead of `rhs.as_linear_rgba_f32()` when the LHS is a `Color::Hsla`. Fixes bevyengine#5543.



Co-authored-by: Verte <105466627+vertesians@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Milestone
No milestone
2 participants
@alice-i-cecile @Gyrobifastigium