Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add audio to ios example #1007

Closed
wants to merge 2 commits into from

Conversation

MichaelHills
Copy link
Contributor

I'm still here :) will try to land the ios audio support in cpal soon and then we can land this.

This PR also adds in assets as a directory reference and avoids the "Xcode is optimizing and breaking my PNGs" issue that I had earlier on during iOS testing on Bevy.

Re-testing this now.

@karroffel karroffel added A-Audio Sounds playback and modification C-Examples An addition or correction to our examples O-iOS Specific to the iOS mobile operating system labels Dec 5, 2020
@alice-i-cecile
Copy link
Member

@MichaelHills if you can verify that this still works I think this should be ready to be merged :)

Base automatically changed from master to main February 19, 2021 20:44
@MichaelHills
Copy link
Contributor Author

Oh CPAL needs a new version released with the iOS support. Then it should be trivial to rebase and land this.

@MichaelHills MichaelHills force-pushed the mike-ios-example branch 2 times, most recently from 58009c5 to 4721279 Compare April 25, 2021 14:46
@MichaelHills MichaelHills marked this pull request as ready for review April 25, 2021 15:06
@MichaelHills
Copy link
Contributor Author

Didn't realise cpal had done a release a month ago, just rebased and re-tested this works on sim + iphone 11.

@MichaelHills
Copy link
Contributor Author

@simlay or @naithar want to help verify this works?

@MichaelHills
Copy link
Contributor Author

@cart this is ready to go, I just retested simulator + my iPhone 11 and the mp3 plays in the background. Not sure anyone else is around to help test.

@cart
Copy link
Member

cart commented May 30, 2021

I trust you :) Thanks for doing this!

@cart
Copy link
Member

cart commented May 30, 2021

bors r+

bors bot pushed a commit that referenced this pull request May 30, 2021
I'm still here :) will try to land the ios audio support in cpal soon and then we can land this.

This PR also adds in assets as a directory reference and avoids the "Xcode is optimizing and breaking my PNGs" issue that I had earlier on during iOS testing on Bevy.

Re-testing this now.
@bors bors bot changed the title Add audio to ios example [Merged by Bors] - Add audio to ios example May 30, 2021
@bors bors bot closed this May 30, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
I'm still here :) will try to land the ios audio support in cpal soon and then we can land this.

This PR also adds in assets as a directory reference and avoids the "Xcode is optimizing and breaking my PNGs" issue that I had earlier on during iOS testing on Bevy.

Re-testing this now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Audio Sounds playback and modification C-Examples An addition or correction to our examples O-iOS Specific to the iOS mobile operating system
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants