Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added plugin registry #13400

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 36 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
7694270
fix: added plugin registry
pietrosophya May 16, 2024
d4b2fad
chore: updating plugins not working fully yet
pietrosophya May 17, 2024
4994fd6
chore: updating plugins not working fully yet
pietrosophya May 17, 2024
06a7c9f
fix: window is running again
pietrosophya May 17, 2024
d0d2fc2
fix: fixed running basic example
pietrosophya May 17, 2024
2f928b5
chore: added docs
pietrosophya May 17, 2024
fa6c448
fix: fixing plugins
pietrosophya May 17, 2024
5ed6fb6
fix: fixing plugins
pietrosophya May 17, 2024
97ff405
fix: fixing plugins
pietrosophya May 17, 2024
a2f36e6
fix: fixing renderer setup
pietrosophya May 17, 2024
1c1dd7e
fix: fixed renderer setup
pietrosophya May 17, 2024
e581bee
Merge branch 'main' into fix/rewrite-plugin-registry
pietrosophya May 17, 2024
94f3b18
Merge branch 'main' into fix/rewrite-plugin-registry
pietrosophya May 18, 2024
0ad4cfb
fix: removed unneeded PlaceholderPlugin and added docs
pietrosophya May 18, 2024
acd6503
fix: extract sub app that must exist
pietrosophya May 18, 2024
569a658
fix: check sub app in ready_to_finalize
pietrosophya May 18, 2024
6bc60c8
chore: fixed some logs
pietrosophya May 18, 2024
a0fd7d2
chore: fixed CI
pietrosophya May 18, 2024
ad4234f
chore: fixed CI
pietrosophya May 18, 2024
ea35d86
Merge branch 'main' into fix/rewrite-plugin-registry
pietrosophya May 18, 2024
686c9ad
chore: fixed CI
pietrosophya May 18, 2024
c86af5e
chore: fixing CI
pietrosophya May 18, 2024
02d7d91
fix: fixed CI tests
pietrosophya May 18, 2024
f0e78f0
fix: fixing CI tests
pietrosophya May 18, 2024
f04d557
fix: fixing CI tests
pietrosophya May 18, 2024
8ae903a
fix: fixing CI tests
pietrosophya May 18, 2024
290e218
Apply suggestions from code review
pietrosophya May 18, 2024
12c9981
chore: fixing comments
pietrosophya May 18, 2024
0db7783
fix: fixing comments
pietrosophya May 19, 2024
a5f03a3
fix: fixing comments
pietrosophya May 19, 2024
997ea33
fix: fixing comments
pietrosophya May 19, 2024
bd95b32
fix: fixing comments
pietrosophya May 19, 2024
0133487
fix: fixing comments
pietrosophya May 19, 2024
cb37cd7
fix: fixing apps
pietrosophya May 19, 2024
1c2631c
Merge branch 'main' into fix/rewrite-plugin-registry
pietrosophya May 19, 2024
4aa6ee5
chore: fix CI
pietrosophya May 19, 2024
4ea8965
chore: merged with main
pietrosophya May 31, 2024
7ab7dab
fix: handling non-unique plugins
pietrosophya May 31, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/bevy_a11y/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use std::sync::{

pub use accesskit;
use accesskit::NodeBuilder;
use bevy_app::Plugin;
use bevy_app::{App, Plugin};
use bevy_derive::{Deref, DerefMut};
use bevy_ecs::{
prelude::{Component, Entity, Event},
Expand Down Expand Up @@ -106,7 +106,7 @@ pub enum AccessibilitySystem {
pub struct AccessibilityPlugin;

impl Plugin for AccessibilityPlugin {
fn build(&self, app: &mut bevy_app::App) {
fn setup(&self, app: &mut App) {
app.init_resource::<AccessibilityRequested>()
.init_resource::<ManageAccessibilityUpdates>()
.init_resource::<Focus>()
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_animation/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1152,7 +1152,7 @@ where
pub struct AnimationPlugin;

impl Plugin for AnimationPlugin {
fn build(&self, app: &mut App) {
fn setup(&self, app: &mut App) {
app.init_asset::<AnimationClip>()
.init_asset::<AnimationGraph>()
.init_asset_loader::<AnimationGraphAssetLoader>()
Expand Down
Loading
Loading