Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Allow deriving SystemParam on private types #1936

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Allow deriving SystemParam on private types #1936

wants to merge 1 commit into from

Conversation

lberrymage
Copy link
Contributor

Examples creating a public type to derive SystemParam on were updated
to create a private type where a public one is no longer needed.

Resolves #1869

@lberrymage
Allow deriving SystemParam on private types
9ddd336 
Examples creating a public type to derive `SystemParam` on were updated
to create a private type where a public one is no longer needed.

Resolves #1869
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples C-Usability A targeted quality-of-life change that makes Bevy easier to use labels Apr 16, 2021
DJMcNab
DJMcNab approved these changes Apr 16, 2021
View reviewed changes
Copy link
Member

@DJMcNab DJMcNab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

I just want to remind any further reviewers that we do still have this running on a public type, namely EventReader, which is still working if tests pass.

@DJMcNab DJMcNab added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 16, 2021
@cart
Copy link
Member

cart commented Apr 16, 2021

bors r+

bors bot pushed a commit that referenced this pull request Apr 16, 2021
@lberrymage
Allow deriving SystemParam on private types (#1936)
d508923 
Examples creating a public type to derive `SystemParam` on were updated
to create a private type where a public one is no longer needed.

Resolves #1869
@bors
Copy link
Contributor

bors bot commented Apr 16, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Allow deriving SystemParam on private types [Merged by Bors] - Allow deriving SystemParam on private types Apr 16, 2021
@bors bors bot closed this Apr 16, 2021
ostwilkens pushed a commit to ostwilkens/bevy that referenced this pull request Jul 27, 2021
@lberrymage @ostwilkens
Allow deriving SystemParam on private types (bevyengine#1936)
038b5b2 
Examples creating a public type to derive `SystemParam` on were updated
to create a private type where a public one is no longer needed.

Resolves bevyengine#1869
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@DJMcNab DJMcNab DJMcNab approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Examples An addition or correction to our examples C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deriving SystemParam fails for non public types
5 participants
@lberrymage @cart @mockersf @DJMcNab @alice-i-cecile