Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite WindowTextureNode to use TextureNode #1998

Closed
wants to merge 8 commits into from
Closed

Rewrite WindowTextureNode to use TextureNode #1998

wants to merge 8 commits into from

Conversation

mtsr
Copy link
Contributor

@mtsr mtsr commented Apr 24, 2021 •
edited
Loading

This is a minor rewrite to make WindowTextureNode reuse TextureNode and expose SamplerDescriptor and Handle arguments in fn new().

I'm using this in #1988

@mtsr mtsr mentioned this pull request Apr 24, 2021
Closed
@Moxinilian Moxinilian added C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it A-Rendering Drawing game state to the screen labels Apr 24, 2021
@mtsr
Copy link
Contributor Author

mtsr commented Apr 27, 2021

Rebased on main.

@mtsr mtsr mentioned this pull request Apr 27, 2021
Closed
@cart cart added the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Jul 23, 2021
@mockersf mockersf removed the S-Pre-Relicense This PR was made before Bevy added the Apache license. Cannot be merged or used for other work label Jul 24, 2021
@mockersf
Copy link
Member

mockersf commented Sep 11, 2021 •
edited
Loading

is this still relevant with the render rewrite?

@cart
Copy link
Member

cart commented Sep 11, 2021

Nope!

@cart cart closed this Sep 11, 2021
@cart
Copy link
Member

cart commented Sep 11, 2021

Window textures are now handled via extracted View entities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart left review comments

@NathanSWard NathanSWard NathanSWard left review comments

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mtsr @mockersf @cart @NathanSWard @Moxinilian