-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new method remove to PluginGroup, also adds unit tests for PluginGroup #2171
Conversation
why not use the |
The root use case here is to reconfigure pub fn add_plugins_fn(group: &mut PluginGroupBuilder) -> &mut PluginGroupBuilder {
group.remove::<bevy_render::RenderPlugin>();
group.add_after::<bevy_scene::ScenePlugin, _>(bevy_render::RenderPlugin {
base_render_graph_config: Some(bevy_render::render_graph::base::BaseRenderGraphConfig {
add_2d_camera: false,
add_3d_camera: false,
add_xr_camera: true,
..Default::default()
}),
});
group
} |
the bug on disabling a plugin and re-adding it with another config is fixed in #2039 👍 |
That's great! I guess renders this PR as obsolete. Seems to contain tests as well |
Are we good to close this PR then? :) |
Ok for me, if there's no other use cases for the remove method |
I don't see any other immediate application of this functionality so I'm going to close this for now. This can be revived if a use case comes up :) |
As requested in #2166