Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add error messages for the spooky insertions #2581

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - Add error messages for the spooky insertions #2581

wants to merge 3 commits into from

Commits on Aug 31, 2021

  1. Add error messages for the spooky insertions

    @DJMcNab
    DJMcNab committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    2b00904 View commit details
    Browse the repository at this point in the history

  2. Rework resolve_unknown_gen 

    Previously, it paniced when the value was
out of the range, it now returns an Option.

It was also erroniously marked as `unsafe`, even though it is
a safe method

I've renamed it - hopefully this rename makes sense

I've also reworked `contains` to use this method,
which allows it to be more precise about
out-of-range entities.
    @DJMcNab
    DJMcNab committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    8624bbe View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2021

  1. Make error messages less useful

    @DJMcNab
    DJMcNab committed Sep 1, 2021
    Configuration menu
    Copy the full SHA
    8a2103e View commit details
    Browse the repository at this point in the history