Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Add missing bytemuck feature #2625

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Add missing bytemuck feature #2625

wants to merge 1 commit into from

Conversation

zicklag
Copy link
Member

@zicklag zicklag commented Aug 9, 2021

Objective

  • Allow you to compile Bevy with the bevy_sprite2 feature, but without the bevy_pbr2 feature.
    • This currently fails because the bevy_sprite2 crate does not require the derive feature of the bytemuck crate in its Cargo.toml, even though it is required to compile.

Solution

  • Add the derive feature of bytemuck to the bevy_sprite2 crate

@zicklag
Add Missing Features to Bytemuck Dependency
d804b28 
When building Bevy with the bevy_sprite2 feature, but without the
bevy_pbr2 feature, the bytemuck crate was missing the "derive" feature.
@zicklag zicklag changed the base branch from main to pipelined-rendering August 9, 2021 16:05
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Aug 9, 2021
@cart
Copy link
Member

cart commented Aug 10, 2021

bors r+

bors bot pushed a commit that referenced this pull request Aug 10, 2021
@zicklag
Add missing bytemuck feature (#2625)
b5b9a95 
# Objective

- Allow you to compile Bevy with the `bevy_sprite2` feature, but without the `bevy_pbr2` feature.
  - This currently fails because the `bevy_sprite2` crate does not require the `derive` feature of the `bytemuck` crate in its `Cargo.toml`, even though it is required to compile.

## Solution

- Add the `derive` feature of `bytemuck` to the `bevy_sprite2` crate
@bors
Copy link
Contributor

bors bot commented Aug 10, 2021

Pull request successfully merged into pipelined-rendering.

Build succeeded:

@bors bors bot changed the title Add missing bytemuck feature [Merged by Bors] - Add missing bytemuck feature Aug 10, 2021
@bors bors bot closed this Aug 10, 2021
@dman-os dman-os mentioned this pull request Aug 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-Needs-Triage This issue needs to be labelled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zicklag @cart