[Merged by Bors] - fix Default implementation of Image so that size and data match
#2833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobhellermann
commented
Sep 16, 2021
jakobhellermann
force-pushed
the
fix-image-default
branch
from
ee78688
to
7eb7efc
Compare
|
Hmm yeah this seems reasonable to me. I kind of liked that Image::default() didn't allocate, but empty images aren't "valid" to wgpu, so we should probably disallow that entirely. This also illustrates a problem: allowing people direct access to these fields also allows them to define data and descriptors that are out of sync. We should probably disallow that / hide the fields to ensure people can only construct "valid" Images. But I won't block this on that :) |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Sep 16, 2021
…2833) Before using this image resulted in an `Error in Queue::write_texture: copy of 0..4 would end up overrunning the bounds of the Source buffer of size 0`
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
bors
bot
changed the title
Default implementation of Image so that size and data matchDefault implementation of Image so that size and data match
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before using this image resulted in an
Error in Queue::write_texture: copy of 0..4 would end up overrunning the bounds of the Source buffer of size 0