[Merged by Bors] - Avoid some format! into immediate format!

[CAD97]

Objective

• Avoid usages of format! that ~immediately get passed to another format!. This avoids a temporary allocation and is just generally cleaner.

Solution

• bevy_derive::shader_defs does a format!("{}", val.to_string()), which is better written as just format!("{}", val)
• bevy_diagnostic::log_diagnostics_plugin does a format!("{:>}", format!(...)), which is better written as format!("{:>}", format_args!(...))
• bevy_ecs::schedule does tracing::info!(..., name = &*format!("{:?}", val)), which is better written with the tracing shorthand tracing::info!(..., name = ?val)
• bevy_reflect::reflect does f.write_str(&format!(...)), which is better written as write!(f, ...) (this could also be written using f.debug_tuple, but I opted to maintain alt debug behavior)
• bevy_reflect::serde::{ser, de} do serde::Error::custom(format!(...)), which is better written as Error::custom(format_args!(...)), as Error::custom takes impl Display and just immediately calls format! again

[alice-i-cecile]

It all checks out. Thanks!

[CAD97]

@bjorn3

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=dde575f6343b3818645f5bb7811bca54

Testing alignment for log_diagnostic

println!("diagnostic with average");
println!("=======================");
println!(
    "{:<name_width$}: {:>12} (avg {:>})",
    diagnostic.name,
    format!("{:.6}{:1}", diagnostic.value, diagnostic.suffix),
    format!("{:.6}{:}", diagnostic.average, diagnostic.suffix),
    name_width = NAME_MAX_WIDTH,
);
println!(
    "{:<name_width$}: {:>12} (avg {:>})",
    diagnostic.name,
    format_args!("{:.6}{:1}", diagnostic.value, diagnostic.suffix),
    format_args!("{:.6}{:}", diagnostic.average, diagnostic.suffix),
    name_width = NAME_MAX_WIDTH,
);
println!(
    "{name:<name_width$}: {value:>11.6}{suffix:1} (avg {average:>.6}{suffix:})",
    name = diagnostic.name,
    value = diagnostic.value,
    suffix = diagnostic.suffix,
    average = diagnostic.average,
    name_width = NAME_MAX_WIDTH,
);

println!();
println!("diagnostic without average");
println!("==========================");
println!(
    "{:<name_width$}: {:>}",
    diagnostic.name,
    format!("{:.6}{:1}", diagnostic.value, diagnostic.suffix),
    name_width = NAME_MAX_WIDTH,
);
println!(
    "{:<name_width$}: {:>}",
    diagnostic.name,
    format_args!("{:.6}{:1}", diagnostic.value, diagnostic.suffix),
    name_width = NAME_MAX_WIDTH,
);
println!(
    "{name:<name_width$}: {value:.6}{suffix:}",
    name = diagnostic.name,
    value = diagnostic.value,
    suffix = diagnostic.suffix,
    name_width = NAME_MAX_WIDTH,
);

diagnostic with average
=======================
name      :   64.000000s (avg 64.000000s)
name      : 64.000000s (avg 64.000000s)
name      :   64.000000s (avg 64.000000s)

diagnostic without average
==========================
name      : 64.000000s
name      : 64.000000s
name      : 64.000000s

I've updated both to just not use format_args! and use named format arguments for clarity. This does not add any structured fields; it might be valuable to add value and average as structured data in the future.

[mockersf]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• build-android
• build (nightly, ubuntu-latest)
• build (stable, macos-latest)
• build (stable, ubuntu-latest)
• build (stable, windows-latest)
• build-wasm (nightly, ubuntu-latest)
• build-wasm (stable, ubuntu-latest)
• check-benches
• check-doc
• check-markdown-links
• check-missing-examples-in-docs
• check-unused-dependencies
• ci
• markdownlint
• run-examples