Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - add some more pipelined-rendering shader examples #3041

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - add some more pipelined-rendering shader examples #3041

wants to merge 9 commits into from

Conversation

jakobhellermann
Copy link
Contributor

based on #3031

Adds some examples showing of how to use the new pipelined rendering for custom shaders.

  • a minimal shader example which doesn't use render assets
  • the same but using glsl
  • an example showing how to render instanced data
  • a shader which uses the seconds since startup to animate some textures

Instancing shader:
grafik
Animated shader:
animate_shader
(the gif makes it look a bit ugly)

@jakobhellermann jakobhellermann force-pushed the shader-examples branch 2 times, most recently from ed9978d to 272d3b0 Compare October 29, 2021 07:01
@jakobhellermann
Copy link
Contributor Author

Currently doesn't work because the msaa sample count doesn't match.

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples hacktoberfest-accepted labels Nov 3, 2021
@jakobhellermann jakobhellermann force-pushed the shader-examples branch 2 times, most recently from 75a9c7e to 22a206b Compare November 13, 2021 10:52
@jakobhellermann
Copy link
Contributor Author

I rebased on top of #3111, msaa works now

@jakobhellermann jakobhellermann force-pushed the shader-examples branch 2 times, most recently from c985ce4 to c5bd6a0 Compare November 18, 2021 16:55
@alice-i-cecile
Copy link
Member

I am very confused by the check-missing-examples-in-docs step failing. If anyone else can spot what's wrong, please let us know!

@alice-i-cecile
Copy link
Member

@jakobhellermann I agree with the observation made on Discord about the CI; can you try it without the wikipedia link?

@jakobhellermann
Copy link
Contributor Author

@jakobhellermann I agree with the observation made on Discord about the CI; can you try it without the wikipedia link?

Yes, that was it. The missing example check is now green.

@jakobhellermann jakobhellermann changed the base branch from pipelined-rendering to main November 25, 2021 16:44
@Elabajaba Elabajaba mentioned this pull request Nov 27, 2021
Closed
@jakobhellermann
Copy link
Contributor Author

rebased on main

@cart cart added this to the Bevy 0.6 milestone Dec 30, 2021
@cart
Copy link
Member

cart commented Jan 5, 2022

bors r+

bors bot pushed a commit that referenced this pull request Jan 5, 2022
@jakobhellermann @cart
add some more pipelined-rendering shader examples (#3041)
b147601 
based on #3031 

Adds some examples showing of how to use the new pipelined rendering for custom shaders.

- a minimal shader example which doesn't use render assets
- the same but using glsl
- an example showing how to render instanced data
- a shader which uses the seconds since startup to animate some textures


Instancing shader:
![grafik](https://user-images.githubusercontent.com/22177966/139299294-e176b62a-53d1-4287-9a66-02fb55affc02.png)
Animated shader:
![animate_shader](https://user-images.githubusercontent.com/22177966/139299718-2940c0f3-8480-4ee0-98d7-b6ba40dc1472.gif)
(the gif makes it look a bit ugly)

Co-authored-by: Carter Anderson <mcanders1@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 5, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title add some more pipelined-rendering shader examples [Merged by Bors] - add some more pipelined-rendering shader examples Jan 5, 2022
@bors bors bot closed this Jan 5, 2022
@jakobhellermann jakobhellermann deleted the shader-examples branch January 5, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elabajaba Elabajaba Elabajaba left review comments

@cart cart cart left review comments

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Examples An addition or correction to our examples
Projects
None yet
Milestone
Bevy 0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@jakobhellermann @alice-i-cecile @cart @Elabajaba