Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Add System Command apply and RenderGraph node spans #3069

Closed
wants to merge 2 commits into from

Conversation

cart
Copy link
Member

@cart cart commented Nov 5, 2021

This fills in most of the gaps in tracing visualizations and should help with discovering bottlenecks.

@cart cart added this to the Bevy 0.6 milestone Nov 5, 2021
@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Needs-Review labels Nov 5, 2021
@cart
Copy link
Member Author

cart commented Nov 5, 2021

Extract stage example showing Command application:
image

Render Graph example illustrating that the MainPass3dNode takes up most of the graph execution time:
image

Copy link
Contributor

@superdump superdump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cart
Copy link
Member Author

cart commented Nov 6, 2021

bors r+

bors bot pushed a commit that referenced this pull request Nov 6, 2021
This fills in most of the gaps in tracing visualizations and should help with discovering bottlenecks.
@bors
Copy link
Contributor

bors bot commented Nov 6, 2021

@bors bors bot changed the title Add System Command apply and RenderGraph node spans [Merged by Bors] - Add System Command apply and RenderGraph node spans Nov 6, 2021
@bors bors bot closed this Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants