Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Only bevy_render should depend directly on wgpu #3393

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Only bevy_render should depend directly on wgpu #3393

wants to merge 2 commits into from

Conversation

mockersf
Copy link
Member

Objective

  • Only bevy_render should depend directly on wgpu
  • This helps to make sure bevy_render re-exports everything needed from wgpu

Solution

  • Remove bevy_pbr, bevy_sprite and bevy_ui dependency on wgpu

@alice-i-cecile alice-i-cecile added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Dec 19, 2021
@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Dec 19, 2021
@mockersf mockersf removed the S-Needs-Triage This issue needs to be labelled label Dec 19, 2021
@cart
Copy link
Member

cart commented Dec 20, 2021

bors r+

bors bot pushed a commit that referenced this pull request Dec 20, 2021
@mockersf
Only bevy_render should depend directly on wgpu (#3393)
c61fbcb 
# Objective

- Only bevy_render should depend directly on wgpu
- This helps to make sure bevy_render re-exports everything needed from wgpu

## Solution

- Remove bevy_pbr, bevy_sprite and bevy_ui dependency on wgpu


Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Dec 20, 2021

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Only bevy_render should depend directly on wgpu [Merged by Bors] - Only bevy_render should depend directly on wgpu Dec 20, 2021
@bors bors bot closed this Dec 20, 2021
mockersf added a commit to mockersf/bevy that referenced this pull request Dec 21, 2021
@mockersf
Only bevy_render should depend directly on wgpu (bevyengine#3393)
136becf 
# Objective

- Only bevy_render should depend directly on wgpu
- This helps to make sure bevy_render re-exports everything needed from wgpu

## Solution

- Remove bevy_pbr, bevy_sprite and bevy_ui dependency on wgpu


Co-authored-by: François <8672791+mockersf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @cart @alice-i-cecile