[Merged by Bors] - Renamed Entity::new to Entity::from_raw #3465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-Scenes
…hin benches/bevy_ecs/commands.rs and benches/bevy_ecs/world_get.rs
…hin benches/bevy_ecs/commands.rs and benches/bevy_ecs/world_get.rs
|
Yup I'm on board for this. Good work! |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Dec 29, 2021
# Objective - Rename `Entity::new(id: u32)` to `Entity::from_raw(id: u32)`. - Add further documentation. - fixes #3108 ## Solution - Renamed `Entity::new(id: u32)` to `Entity::from_raw(id: u32)`. - Docs extended. I derived the examples from the discussion of issue #3108 . The [first case](#3108 (comment)) mentioned in the linked issue is quite obvious but the [second one](#3108 (comment)) probably needs further explanation. Co-authored-by: r4gus <david@thesugar.de>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
mockersf
pushed a commit
to mockersf/bevy
that referenced
this pull request
Jan 1, 2022
# Objective - Rename `Entity::new(id: u32)` to `Entity::from_raw(id: u32)`. - Add further documentation. - fixes bevyengine#3108 ## Solution - Renamed `Entity::new(id: u32)` to `Entity::from_raw(id: u32)`. - Docs extended. I derived the examples from the discussion of issue bevyengine#3108 . The [first case](bevyengine#3108 (comment)) mentioned in the linked issue is quite obvious but the [second one](bevyengine#3108 (comment)) probably needs further explanation. Co-authored-by: r4gus <david@thesugar.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Entity::new(id: u32)toEntity::from_raw(id: u32).Entity::new(id: u32)tofrom_raw#3108Solution
Entity::new(id: u32)toEntity::from_raw(id: u32).I derived the examples from the discussion of issue #3108 .
The first case mentioned in the linked issue is quite obvious but the second one probably needs further explanation.