Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve sprite ordering speed #3554

Closed
wants to merge 2 commits into from
Closed

Improve sprite ordering speed #3554

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80ce18e
use partial_cmp
mockersf Jan 5, 2022
7095163
use unstable sort
mockersf Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions crates/bevy_sprite/src/render/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,10 +322,10 @@ pub fn prepare_sprites(

// sort first by z and then by handle. this ensures that, when possible, batches span multiple z layers
// batches won't span z-layers if there is another batch between them
extracted_sprites.sprites.sort_by(|a, b| {
match FloatOrd(a.transform.w_axis[2]).cmp(&FloatOrd(b.transform.w_axis[2])) {
Ordering::Equal => a.handle.cmp(&b.handle),
other => other,
extracted_sprites.sprites.sort_unstable_by(|a, b| {
match a.transform.w_axis[2].partial_cmp(&b.transform.w_axis[2]) {
Some(Ordering::Equal) | None => a.handle.cmp(&b.handle),
Some(other) => other,
}
});

Expand Down