Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SquarePrism shape into mesh #377

Closed
wants to merge 7 commits into from
Closed

Add SquarePrism shape into mesh #377

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5a4b70c
Add SquarePrism shape into mesh
Aug 27, 2020
416bde6
Format with cargo fmt
Aug 27, 2020
07736a4
Rename SquarePrism to RectangularPrism as it is not necessarily square
Aug 27, 2020
390b8ab
Change default the default prism shape from a cube to a rectangular p…
Aug 27, 2020
33829ba
Fix comments since the rename of SquarePrism into RectangularPrism
Aug 27, 2020
4f189df
Add a constructor with length, width and height to RectangularPrism
Aug 27, 2020
179cb81
Fix constructor division issue
Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix comments since the rename of SquarePrism into RectangularPrism
  • Loading branch information
Jason Lessard committed Aug 27, 2020
commit 33829ba9c7a4e903fb8063308c4ea2f1c6de8d58
5 changes: 3 additions & 2 deletions crates/bevy_render/src/mesh/mesh.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ pub mod shape {
use bevy_math::*;
use hexasphere::Hexasphere;

/// A cube -> SquarePrism where all length of sides are the same.
/// A cube -> RectangularPrism where all length of sides are the same.
pub struct Cube {
/// Half the side length of the cube.
pub size: f32,
Expand Down Expand Up @@ -401,7 +401,8 @@ pub mod shape {
}
}

/// A Square prism. Just like a cube, but you can specify the dimensions.
/// A aectangular prism. Just like a cube, but you can specify the
/// length of each dimensions.
pub struct RectangularPrism {
pub min_x: f32,
pub max_x: f32,
Expand Down