[Merged by Bors] - Add FocusPolicy to NodeBundle and ImageBundle #3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-UI
|
Cool! This is absolutely useful, and your reasoning is great. Thanks for the first contribution :) |
alice-i-cecile
approved these changes
Feb 14, 2022
|
I'm on board for this change. We should definitely try to include relevant components in bundles whenever possible, to improve discoverability. |
|
(and future editor scenarios) |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 15, 2022
# Objective `FocusPolicy` allows tracking `Interaction` of a parent node when a player hovers/clicks at the child node, and I see no reason why it shouldn't exist in these 2 nodes. Resolves #2488 ## Solution Add it! In the tracking system it's used as `Option`: https://github.com/bevyengine/bevy/blob/e749ee786c3a3ca11718b08f0545aa90e4b5aae6/crates/bevy_ui/src/focus.rs#L71 and then it treats it as `Block` if it's not present: https://github.com/bevyengine/bevy/blob/e749ee786c3a3ca11718b08f0545aa90e4b5aae6/crates/bevy_ui/src/focus.rs#L162 and the default value is https://github.com/bevyengine/bevy/blob/e749ee786c3a3ca11718b08f0545aa90e4b5aae6/crates/bevy_ui/src/focus.rs#L47-L51 so it should be compatible with all existing UIs that use `..Default::default()`
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
FocusPolicyallows trackingInteractionof a parent node when a player hovers/clicks at the child node, and I see no reason why it shouldn't exist in these 2 nodes.Resolves #2488
Solution
Add it!
In the tracking system it's used as
Option:bevy/crates/bevy_ui/src/focus.rs
Line 71 in e749ee7
Blockif it's not present:bevy/crates/bevy_ui/src/focus.rs
Line 162 in e749ee7
bevy/crates/bevy_ui/src/focus.rs
Lines 47 to 51 in e749ee7
..Default::default()