Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - bevy_reflect: IntoIter for DynamicList and DynamicMap #4108

Closed
wants to merge 3 commits into from

Conversation

MrGVSV
Copy link
Member

@MrGVSV MrGVSV commented Mar 5, 2022

Objective

In some cases, you may want to take ownership of the values in DynamicList or DynamicMap.

I came across this need while trying to implement a custom deserializer, but couldn't get ownership of the values in the list.

Solution

Implemented IntoIter for both DynamicList and DynamicMap.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Mar 5, 2022
@mockersf mockersf added A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled labels Mar 5, 2022
@MrGVSV
Copy link
Member Author

MrGVSV commented Mar 5, 2022

Not sure why CI failed. Fixed an unrelated issue using markdownlint -f -c .github/linters/.markdown-lint.yml . in hopes that it resolves it.

@mockersf
Copy link
Member

mockersf commented Mar 5, 2022

CI error was due to a network error and should be ignored, no need to fix the markdown in this PR 👍

@MrGVSV
Copy link
Member Author

MrGVSV commented Mar 5, 2022

CI error was due to a network error and should be ignored, no need to fix the markdown in this PR 👍

Ah, makes sense. I'll revert.

@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 5, 2022
@MrGVSV MrGVSV changed the title IntoIter for DynamicList and DynamicMap bevy_reflect: IntoIter for DynamicList and DynamicMap Mar 28, 2022
@alice-i-cecile alice-i-cecile added this to the Bevy 0.8 milestone Apr 25, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 25, 2022
# Objective

In some cases, you may want to take ownership of the values in `DynamicList` or `DynamicMap`. 

I came across this need while trying to implement a custom deserializer, but couldn't get ownership of the values in the list.

## Solution

Implemented `IntoIter` for both `DynamicList` and `DynamicMap`.
@bors
Copy link
Contributor

bors bot commented Apr 25, 2022

Build failed (retrying...):

@alice-i-cecile
Copy link
Member

@MrGVSV looks like this needs to be reformatted.

@alice-i-cecile
Copy link
Member

bors r-

@bors
Copy link
Contributor

bors bot commented Apr 25, 2022

Canceled.

@MrGVSV
Copy link
Member Author

MrGVSV commented Apr 25, 2022

@MrGVSV looks like this needs to be reformatted.

@alice-i-cecile I just did a quick cargo fmt --all and it didn't do anything 😅

@alice-i-cecile
Copy link
Member

Okay 🤔 Well, let's try again. If this fails, I think you should try rebasing.

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 25, 2022
# Objective

In some cases, you may want to take ownership of the values in `DynamicList` or `DynamicMap`. 

I came across this need while trying to implement a custom deserializer, but couldn't get ownership of the values in the list.

## Solution

Implemented `IntoIter` for both `DynamicList` and `DynamicMap`.
@bors
Copy link
Contributor

bors bot commented Apr 25, 2022

Timed out.

1 similar comment
@bors
Copy link
Contributor

bors bot commented Apr 25, 2022

Timed out.

@MrGVSV
Copy link
Member Author

MrGVSV commented Apr 25, 2022

Hm, okay I'll try a rebase then.

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 25, 2022
# Objective

In some cases, you may want to take ownership of the values in `DynamicList` or `DynamicMap`. 

I came across this need while trying to implement a custom deserializer, but couldn't get ownership of the values in the list.

## Solution

Implemented `IntoIter` for both `DynamicList` and `DynamicMap`.
@bors
Copy link
Contributor

bors bot commented Apr 26, 2022

Build failed:

@alice-i-cecile
Copy link
Member

@MrGVSV looks like you got bitten by a rebase and accidentally changed CONTRIBUTING.md. Can you revert that?

@MrGVSV
Copy link
Member Author

MrGVSV commented Apr 26, 2022

@MrGVSV looks like you got bitten by a rebase and accidentally changed CONTRIBUTING.md. Can you revert that?

Sorry about that (you can tell I don't rebase much haha)

@alice-i-cecile
Copy link
Member

No worries; git can be a real pain at times.

@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 26, 2022
# Objective

In some cases, you may want to take ownership of the values in `DynamicList` or `DynamicMap`. 

I came across this need while trying to implement a custom deserializer, but couldn't get ownership of the values in the list.

## Solution

Implemented `IntoIter` for both `DynamicList` and `DynamicMap`.
@bors bors bot changed the title bevy_reflect: IntoIter for DynamicList and DynamicMap [Merged by Bors] - bevy_reflect: IntoIter for DynamicList and DynamicMap Apr 26, 2022
@bors bors bot closed this Apr 26, 2022
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
…ne#4108)

# Objective

In some cases, you may want to take ownership of the values in `DynamicList` or `DynamicMap`. 

I came across this need while trying to implement a custom deserializer, but couldn't get ownership of the values in the list.

## Solution

Implemented `IntoIter` for both `DynamicList` and `DynamicMap`.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…ne#4108)

# Objective

In some cases, you may want to take ownership of the values in `DynamicList` or `DynamicMap`. 

I came across this need while trying to implement a custom deserializer, but couldn't get ownership of the values in the list.

## Solution

Implemented `IntoIter` for both `DynamicList` and `DynamicMap`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants