Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Nested spawns on scope #4466

Closed
wants to merge 30 commits into from
Closed

[Merged by Bors] - Nested spawns on scope #4466

wants to merge 30 commits into from

Commits on Sep 14, 2022

  1. convert scope.spawn_local to scoped executor 

    Co-authored-by: TheRawMeatball <therawmeatball@gmail.com>
    @hymm @TheRawMeatball
    hymm and TheRawMeatball committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    31f8e41 View commit details
    Browse the repository at this point in the history

  2. copy test from bevyengine#4343 

    Co-authored-by: MiniaczQ <MiniaczQ@gmail.com>
    @hymm
    2 people authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    f02b982 View commit details
    Browse the repository at this point in the history

  3. convert to using a concurrent queue for interior mutability

    @hymm
    Michael Hsu authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    c69dc7c View commit details
    Browse the repository at this point in the history

  4. remove optimization 

    not correct as a single task can spawn more tasks
    @hymm
    Michael Hsu authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    a08dc5b View commit details
    Browse the repository at this point in the history

  5. remove if statement 

    better perf on more than one spawn, at cost to one spawn or zero spawns being slower
    @hymm
    Michael Hsu authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    4f46d10 View commit details
    Browse the repository at this point in the history

  6. check locality of scope_on_scope for nested spawns

    @hymm
    Michael Hsu authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    b93d70e View commit details
    Browse the repository at this point in the history

  7. update some comments

    @hymm
    Michael Hsu authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    eeb6aeb View commit details
    Browse the repository at this point in the history

  8. transmute scope ref to &'scope to get rid of Arc

    @hymm
    Michael Hsu authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    666f2d2 View commit details
    Browse the repository at this point in the history

  9. clarify safety comment

    @hymm
    Michael Hsu authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    27187d9 View commit details
    Browse the repository at this point in the history

  10. add a test for UB

    @hymm
    Michael Hsu authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    69fa59b View commit details
    Browse the repository at this point in the history

  11. copy lifetimes from std scope

    @hymm
    Michael Hsu authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    069750f View commit details
    Browse the repository at this point in the history

  12. add compile fail test

    @hymm
    Michael Hsu authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    ffc9688 View commit details
    Browse the repository at this point in the history

  13. clean up comments

    @hymm
    Michael Hsu authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    79c4b4e View commit details
    Browse the repository at this point in the history

  14. change single threaded task pool type signatures to match changes

    @hymm
    Michael Hsu authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    ea2fcef View commit details
    Browse the repository at this point in the history

  15. fix doc comment

    @hymm
    Michael Hsu authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    b523732 View commit details
    Browse the repository at this point in the history

  16. change Arc to immutable reference

    @hymm
    Michael Hsu authored and hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    575ae94 View commit details
    Browse the repository at this point in the history

  17. add another compile fail test

    @hymm
    hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    2aae929 View commit details
    Browse the repository at this point in the history

  18. match lifetime of return value to lifetimes of futures

    @hymm
    hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    aa051ec View commit details
    Browse the repository at this point in the history

  19. rework executor code for performance

    @hymm
    hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    97da059 View commit details
    Browse the repository at this point in the history

  20. add invariance of lifetimes to single threaded executor

    @hymm
    hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    624e282 View commit details
    Browse the repository at this point in the history

  21. add some docs about the lifetimes

    @hymm
    hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    b2b6756 View commit details
    Browse the repository at this point in the history

  22. fix doc link

    @hymm
    hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    4f38e53 View commit details
    Browse the repository at this point in the history

  23. fix some issues from rebase

    @hymm
    hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    f60d41d View commit details
    Browse the repository at this point in the history

  24. run cargo fmt

    @hymm
    hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    0279dd1 View commit details
    Browse the repository at this point in the history

  25. fix new clippy error

    @hymm
    hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    b48b056 View commit details
    Browse the repository at this point in the history

  26. revert change to executor

    @hymm
    hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    57bf8ca View commit details
    Browse the repository at this point in the history

  27. fix rebase formatting issues

    @hymm
    hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    2e6e438 View commit details
    Browse the repository at this point in the history

  28. change lifetimes to match std

    @hymm
    hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    243ae2f View commit details
    Browse the repository at this point in the history

  29. fix rebase error

    @hymm
    hymm committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    e4ad01d View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2022

  1. Merge remote-tracking branch 'origin/main' into pr/hymm/4466

    @cart
    cart committed Sep 27, 2022
    Configuration menu
    Copy the full SHA
    a73f6e9 View commit details
    Browse the repository at this point in the history