Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Use elapsed() method on Instant in examples/async_tasks/async_compute.rs #4497

Closed
wants to merge 1 commit into from

Conversation

agluszak
Copy link

Objective

Make the example a tiny bit more elegant

Solution

Change one line


Changelog

This section is optional. If this was a trivial fix, or has no externally-visible impact, feel free to skip this section.

  • What changed as a result of this PR?
  • If applicable, organize changes under "Added", "Changed", or "Fixed" sub-headings
  • Stick to one or two sentences. If more detail is needed for a particular change, consider adding it to the "Solution" section
    • If you can't summarize the work, your change may be unreasonably large / unrelated. Consider splitting your PR to make it easier to review and merge!

Migration Guide

This section is optional

  • If this PR is a breaking change (relative to the last release of Bevy), describe how a user might need to migrate their code to support these changes
  • Simply adding new functionality is not a breaking change.
  • Fixing behavior that was definitely a bug, rather than a questionable design choice is not a breaking change.

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Apr 16, 2022
@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples A-Tasks Tools for parallel and async work C-Code-Quality A section of code that is hard to understand or change and removed S-Needs-Triage This issue needs to be labelled labels Apr 16, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Apr 16, 2022
….rs (#4497)

# Objective

Make the example a tiny bit more elegant

## Solution

Change one line

---

## Changelog

> This section is optional. If this was a trivial fix, or has no externally-visible impact, feel free to skip this section.

- What changed as a result of this PR?
- If applicable, organize changes under "Added", "Changed", or "Fixed" sub-headings
- Stick to one or two sentences. If more detail is needed for a particular change, consider adding it to the "Solution" section
  - If you can't summarize the work, your change may be unreasonably large / unrelated. Consider splitting your PR to make it easier to review and merge!

## Migration Guide

> This section is optional

- If this PR is a breaking change (relative to the last release of Bevy), describe how a user might need to migrate their code to support these changes
- Simply adding new functionality is not a breaking change.
- Fixing behavior that was definitely a bug, rather than a questionable design choice is not a breaking change.
@alice-i-cecile
Copy link
Member

Thanks! It's nice to make little improvements like this when we find them.

@bors bors bot changed the title Use elapsed() method on Instant in examples/async_tasks/async_compute.rs [Merged by Bors] - Use elapsed() method on Instant in examples/async_tasks/async_compute.rs Apr 16, 2022
@bors bors bot closed this Apr 16, 2022
@IceSentry
Copy link
Contributor

@agluszak could you make this PR again, but targeting main instead of latest?

bors bot pushed a commit that referenced this pull request Apr 26, 2022
# Objective

- reopen #4497 on main
- Make the example a tiny bit more elegant
exjam pushed a commit to exjam/bevy that referenced this pull request May 22, 2022
# Objective

- reopen bevyengine#4497 on main
- Make the example a tiny bit more elegant
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

- reopen bevyengine#4497 on main
- Make the example a tiny bit more elegant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tasks Tools for parallel and async work C-Code-Quality A section of code that is hard to understand or change C-Examples An addition or correction to our examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants