Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Clean up Fetch code #4800

Closed
wants to merge 51 commits into from

Commits on May 18, 2022

  1. Get started

    james7132 committed May 18, 2022
    Configuration menu
    Copy the full SHA
    5b4edee View commit details
    Browse the repository at this point in the history
  2. get it to compile

    james7132 committed May 18, 2022
    Configuration menu
    Copy the full SHA
    08178ac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    550ebfe View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    24c6d59 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    729d174 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. Fix WorldQuery derive macro

    james7132 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    a925fc3 View commit details
    Browse the repository at this point in the history
  2. Add missing safety docs

    james7132 committed May 19, 2022
    Configuration menu
    Copy the full SHA
    ed0c1a3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6cfcbcc View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. Configuration menu
    Copy the full SHA
    cac2927 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2022

  1. Configuration menu
    Copy the full SHA
    f1b4da5 View commit details
    Browse the repository at this point in the history
  2. Fix build from bad merge

    james7132 committed May 30, 2022
    Configuration menu
    Copy the full SHA
    389477f View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. Remove transmutes

    james7132 committed May 31, 2022
    Configuration menu
    Copy the full SHA
    95f57d7 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary lifetime

    james7132 committed May 31, 2022
    Configuration menu
    Copy the full SHA
    8fef6c8 View commit details
    Browse the repository at this point in the history
  3. Revert code duplication.

    james7132 committed May 31, 2022
    Configuration menu
    Copy the full SHA
    91eda72 View commit details
    Browse the repository at this point in the history
  4. Fix AnyOf density

    james7132 committed May 31, 2022
    Configuration menu
    Copy the full SHA
    4ea8e34 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3fbe9ea View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    637e981 View commit details
    Browse the repository at this point in the history
  7. Remove outdated comments

    james7132 committed May 31, 2022
    Configuration menu
    Copy the full SHA
    7b44be9 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Configuration menu
    Copy the full SHA
    9392d09 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    255c481 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2022

  1. Configuration menu
    Copy the full SHA
    d96461f View commit details
    Browse the repository at this point in the history
  2. Remove unsafe on FetchState

    james7132 committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    c04ee45 View commit details
    Browse the repository at this point in the history
  3. Fix docs

    james7132 committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    ed72c4c View commit details
    Browse the repository at this point in the history
  4. Reference to value

    james7132 committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    4d27afc View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2022

  1. Formatting

    james7132 committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    50b52ae View commit details
    Browse the repository at this point in the history
  2. Fix up WorldQuery derives

    james7132 committed Jun 21, 2022
    Configuration menu
    Copy the full SHA
    49ae4b6 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Configuration menu
    Copy the full SHA
    1789404 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Configuration menu
    Copy the full SHA
    4ca8881 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2022

  1. Documenting BufferVec. (bevyengine#4673)

    # Objective
    
    Documents the `BufferVec` render resource.
    
    `BufferVec` is a fairly low level object, that will likely be managed by a higher level API (e.g. through [`encase`](bevyengine#4272)) in the future. For now, since it is still used by some simple 
    example crates (e.g. [bevy-vertex-pulling](https://github.com/superdump/bevy-vertex-pulling)), it will be helpful
    to provide some simple documentation on what `BufferVec` does.  
    
    ## Solution
    
    I looked through Discord discussion on `BufferVec`, and found [a comment](https://discord.com/channels/691052431525675048/953222550568173580/956596218857918464 ) by @superdump to be particularly helpful, in the general discussion around `encase`. 
    
    I have taken care to clarify where the data is stored (host-side), when the device-side buffer is created (through calls to `reserve`), and when data writes from host to device are scheduled (using `write_buffer` calls). 
    
    ---
    
    ## Changelog
    
    - Added doc string for `BufferVec` and two of its methods: `reserve` and `write_buffer`. 
    
    
    Co-authored-by: Brian Merchant <bhmerchant@gmail.com>
    2 people authored and james7132 committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    255e306 View commit details
    Browse the repository at this point in the history
  2. Fix Events example link (bevyengine#5126)

    The `crate` intermediate directory is missing from the path, which currently leads to 404.
    64kramsystem authored and james7132 committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    696a187 View commit details
    Browse the repository at this point in the history
  3. Update ExactSizeIterator impl to support archetypal filters (With, …

    …Without) (bevyengine#5124)
    
    # Objective
    
    - Fixes bevyengine#3142
    
    ## Solution
    
    - Done according to bevyengine#3142
    - Created new marker trait `ArchetypeFilter`
    - Implement said trait to:
      - `With<T>`
      - `Without<T>`
      - tuples containing only types that implement `ArchetypeFilter`, from 0 to 15 elements
      - `Or<T>` where T is a tuple as described previously
    - Changed `ExactSizeIterator` impl to include a new generic that must implement `WorldQuery` and `ArchetypeFilter`
    - Added new tests
    
    ---
    
    ## Changelog
    
    ### Added
    - `Query`s with archetypal filters can now use `.iter().len()` to get the exact size of the iterator.
    harudagondi authored and james7132 committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    d1e8773 View commit details
    Browse the repository at this point in the history
  4. Wider ECS Benchmarks (bevyengine#5123)

    # Objective
    As a part of evaluating bevyengine#4800, at the behest of @cart, it was noted that the ECS microbenchmarks all focus on singular component queries, whereas in reality most systems will have wider queries with multiple components in each.
    
    ## Solution
    Use const generics to add wider variants of existing benchmarks.
    james7132 committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    ba28b0d View commit details
    Browse the repository at this point in the history
  5. fix resource not found error message (bevyengine#5128)

    There are some outdated error messages for when a resource is not found. It references `add_resource` and `add_non_send_resource` which were renamed to `insert_resource` and `insert_non_send_resource`.
    hymm authored and james7132 committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    cce14dd View commit details
    Browse the repository at this point in the history
  6. Move texture sample out of branch in prepare_normal (bevyengine#5129)

    # Objective
    
    This fixes bevyengine#5127
    
    ## Solution
    
    - Moved texture sample out of branch in `prepare_normal()`.
    
    
    Co-authored-by: DGriffin91 <github@dgdigital.net>
    2 people authored and james7132 committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    da59bbd View commit details
    Browse the repository at this point in the history
  7. Fix typos in bevy_reflect readme (bevyengine#5134)

    # Objective
    
    Fix some typos in bevy_reflect's readme
    
    ## Solution
    
    - Change `Foo`'s `d` field to be of type `Vec<Baz>`
    - Format `&dyn Reflect` to be monospace
    grace125 authored and james7132 committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    5bc5adb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    aa04589 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b32681c View commit details
    Browse the repository at this point in the history
  10. Fix WorldQuery macro

    james7132 committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    38f5ea4 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    815072f View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    0dbf1c9 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2022

  1. Configuration menu
    Copy the full SHA
    44c8f86 View commit details
    Browse the repository at this point in the history
  2. Fix build

    james7132 committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    eb2c6a4 View commit details
    Browse the repository at this point in the history
  3. Fix CI

    james7132 committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    7f794ed View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2c31e05 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Remove EntityFetch

    james7132 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    24b0b99 View commit details
    Browse the repository at this point in the history
  2. Fix up the doc comment

    james7132 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    2832c04 View commit details
    Browse the repository at this point in the history
  3. Fix rebase error

    james7132 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    659f644 View commit details
    Browse the repository at this point in the history
  4. Fix up the doc comment

    james7132 committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    92cc6e1 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Configuration menu
    Copy the full SHA
    8d1beee View commit details
    Browse the repository at this point in the history
  2. Fix CI

    james7132 committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    47ad0d1 View commit details
    Browse the repository at this point in the history
  3. Address review comments

    james7132 committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    8f9f568 View commit details
    Browse the repository at this point in the history