Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - bevy_reflect: support map insertion #5173

Closed
wants to merge 5 commits into from

Conversation

james7132
Copy link
Member

Objective

This is a rebase of #3701 which is currently scheduled for 0.8 but is marked for adoption.

Fixes #3609

Solution

  • add an insert_boxed() method on the Map trait
  • implement it for HashMap using a new FromReflect generic bound
  • add a map_apply() helper method to implement Map::apply(), that inserts new values instead of ignoring them

Changelog

TODO

@james7132 james7132 added this to the Bevy 0.8 milestone Jul 1, 2022
@james7132 james7132 added C-Feature A new feature, making something new possible A-Reflection Runtime information about types labels Jul 1, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 2, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 4, 2022
# Objective

This is a rebase of #3701 which is currently scheduled for 0.8 but is marked for adoption.

> Fixes #3609

## Solution
> - add an `insert_boxed()` method on the `Map` trait
> - implement it for `HashMap` using a new `FromReflect` generic bound
> - add a `map_apply()` helper method to implement `Map::apply()`, that inserts new values instead of ignoring them


---

## Changelog
TODO

Co-authored-by: james7132 <contact@jamessliu.com>
@bors bors bot changed the title bevy_reflect: support map insertion [Merged by Bors] - bevy_reflect: support map insertion Jul 4, 2022
@bors bors bot closed this Jul 4, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
# Objective

This is a rebase of bevyengine#3701 which is currently scheduled for 0.8 but is marked for adoption.

> Fixes bevyengine#3609

## Solution
> - add an `insert_boxed()` method on the `Map` trait
> - implement it for `HashMap` using a new `FromReflect` generic bound
> - add a `map_apply()` helper method to implement `Map::apply()`, that inserts new values instead of ignoring them


---

## Changelog
TODO

Co-authored-by: james7132 <contact@jamessliu.com>
james7132 added a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

This is a rebase of bevyengine#3701 which is currently scheduled for 0.8 but is marked for adoption.

> Fixes bevyengine#3609

## Solution
> - add an `insert_boxed()` method on the `Map` trait
> - implement it for `HashMap` using a new `FromReflect` generic bound
> - add a `map_apply()` helper method to implement `Map::apply()`, that inserts new values instead of ignoring them


---

## Changelog
TODO

Co-authored-by: james7132 <contact@jamessliu.com>
@james7132 james7132 deleted the fix_reflect_map_apply branch December 12, 2022 06:45
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

This is a rebase of bevyengine#3701 which is currently scheduled for 0.8 but is marked for adoption.

> Fixes bevyengine#3609

## Solution
> - add an `insert_boxed()` method on the `Map` trait
> - implement it for `HashMap` using a new `FromReflect` generic bound
> - add a `map_apply()` helper method to implement `Map::apply()`, that inserts new values instead of ignoring them


---

## Changelog
TODO

Co-authored-by: james7132 <contact@jamessliu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Reflection Runtime information about types C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants