Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Update Notify Dependency #5396

Closed
wants to merge 1 commit into from

Conversation

zicklag
Copy link
Member

@zicklag zicklag commented Jul 20, 2022

Objective

I want to use the deno_runtime crate in my game, but it has a conflict with the version of the notify crate that Bevy depends on.

Solution

Updates the version of the notify crate the Bevy depends on.

@alice-i-cecile alice-i-cecile added the C-Dependencies A change to the crates that Bevy depends on label Jul 20, 2022
@mockersf
Copy link
Member

replaces #4859 and #2993

@zicklag
Copy link
Member Author

zicklag commented Jul 20, 2022

Just tested, hot reload still works on the Bevy example and on my game.

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jul 20, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Jul 20, 2022
# Objective

I want to use the `deno_runtime` crate in my game, but it has a conflict with the version of the `notify` crate that Bevy depends on.

## Solution

Updates the version of the `notify` crate the Bevy depends on.
@mockersf
Copy link
Member

mockersf commented Jul 20, 2022

notify is very platform dependent and would need to be tested on all platforms.

That said, the changelog seems OK and I'm inclined to trust the crate

@zicklag
Copy link
Member Author

zicklag commented Jul 20, 2022

Just for the record, then, I tested on Pop!_OS ( Ubuntu ) 20.04:

$ uname -a
Linux pop-os 5.13.0-7614-generic #14~1631647151~20.04~930e87c-Ubuntu SMP Fri Sep 17 00:26:31 UTC  x86_64 x86_64 x86_64 GNU/Linux

@bors bors bot changed the title Update Notify Dependency [Merged by Bors] - Update Notify Dependency Jul 20, 2022
@bors bors bot closed this Jul 20, 2022
inodentry pushed a commit to IyesGames/bevy that referenced this pull request Aug 8, 2022
# Objective

I want to use the `deno_runtime` crate in my game, but it has a conflict with the version of the `notify` crate that Bevy depends on.

## Solution

Updates the version of the `notify` crate the Bevy depends on.
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

I want to use the `deno_runtime` crate in my game, but it has a conflict with the version of the `notify` crate that Bevy depends on.

## Solution

Updates the version of the `notify` crate the Bevy depends on.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

I want to use the `deno_runtime` crate in my game, but it has a conflict with the version of the `notify` crate that Bevy depends on.

## Solution

Updates the version of the `notify` crate the Bevy depends on.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Dependencies A change to the crates that Bevy depends on S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants