Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix spot dir nan bug #6167

Closed
wants to merge 1 commit into from

Conversation

robtfm
Copy link
Contributor

@robtfm robtfm commented Oct 4, 2022

Objective

fix error with pbr shader's spotlight direction calculation when direction.y ~= 0

Solution

in pbr_lighting.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it

@IceSentry IceSentry added the A-Rendering Drawing game state to the screen label Oct 4, 2022
@alice-i-cecile alice-i-cecile added the C-Bug An unexpected or incorrect behavior label Oct 4, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 4, 2022
@alice-i-cecile
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Oct 5, 2022
# Objective

fix error with pbr shader's spotlight direction calculation when direction.y ~= 0

## Solution

in pbr_lighting.wgsl, clamp `1-x^2-z^2` to `>= 0` so that we can safely `sqrt` it
@bors bors bot changed the title fix spot dir nan bug [Merged by Bors] - fix spot dir nan bug Oct 5, 2022
@bors bors bot closed this Oct 5, 2022
xgbwei pushed a commit to xgbwei/bevy that referenced this pull request Oct 5, 2022
# Objective

fix error with pbr shader's spotlight direction calculation when direction.y ~= 0

## Solution

in pbr_lighting.wgsl, clamp `1-x^2-z^2` to `>= 0` so that we can safely `sqrt` it
@robtfm robtfm deleted the spotdir_nan_fix branch October 10, 2022 20:17
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
# Objective

fix error with pbr shader's spotlight direction calculation when direction.y ~= 0

## Solution

in pbr_lighting.wgsl, clamp `1-x^2-z^2` to `>= 0` so that we can safely `sqrt` it
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
# Objective

fix error with pbr shader's spotlight direction calculation when direction.y ~= 0

## Solution

in pbr_lighting.wgsl, clamp `1-x^2-z^2` to `>= 0` so that we can safely `sqrt` it
bors bot pushed a commit that referenced this pull request Jan 13, 2023
# Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes #7152

## Solution

same as #6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
bors bot pushed a commit that referenced this pull request Jan 13, 2023
# Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes #7152

## Solution

same as #6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
bors bot pushed a commit that referenced this pull request Jan 13, 2023
# Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes #7152

## Solution

same as #6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
bors bot pushed a commit that referenced this pull request Jan 13, 2023
# Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes #7152

## Solution

same as #6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
bors bot pushed a commit that referenced this pull request Jan 13, 2023
# Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes #7152

## Solution

same as #6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
# Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes bevyengine#7152

## Solution

same as bevyengine#6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

fix error with pbr shader's spotlight direction calculation when direction.y ~= 0

## Solution

in pbr_lighting.wgsl, clamp `1-x^2-z^2` to `>= 0` so that we can safely `sqrt` it
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

fix error with shadow shader's spotlight direction calculation when direction.y ~= 0
fixes bevyengine#7152

## Solution

same as bevyengine#6167: in shadows.wgsl, clamp 1-x^2-z^2 to >= 0 so that we can safely sqrt it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants