Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Fix clipping in UI #6351

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Fix clipping in UI #6351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c48f491
fix clipping
mockersf Oct 23, 2022
c7ac764
don't update every frame
mockersf Oct 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions crates/bevy_ui/src/render/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ pub struct ExtractedUiNode {
pub image: Handle<Image>,
pub atlas_size: Option<Vec2>,
pub clip: Option<Rect>,
pub scale_factor: f32,
}

#[derive(Resource, Default)]
Expand All @@ -176,6 +177,7 @@ pub struct ExtractedUiNodes {
pub fn extract_uinodes(
mut extracted_uinodes: ResMut<ExtractedUiNodes>,
images: Extract<Res<Assets<Image>>>,
windows: Extract<Res<Windows>>,
uinode_query: Extract<
Query<(
&Node,
Expand All @@ -187,6 +189,7 @@ pub fn extract_uinodes(
)>,
>,
) {
let scale_factor = windows.scale_factor(WindowId::primary()) as f32;
extracted_uinodes.uinodes.clear();
for (uinode, transform, color, image, visibility, clip) in uinode_query.iter() {
if !visibility.is_visible() {
Expand All @@ -211,6 +214,7 @@ pub fn extract_uinodes(
image,
atlas_size: None,
clip: clip.map(|clip| clip.clip),
scale_factor,
});
}
}
Expand Down Expand Up @@ -330,6 +334,7 @@ pub fn extract_text_uinodes(
image: texture,
atlas_size,
clip: clip.map(|clip| clip.clip),
scale_factor,
});
}
}
Expand Down Expand Up @@ -464,20 +469,20 @@ pub fn prepare_uinodes(
let atlas_extent = extracted_uinode.atlas_size.unwrap_or(uinode_rect.max);
let uvs = [
Vec2::new(
uinode_rect.min.x + positions_diff[3].x,
uinode_rect.min.y - positions_diff[3].y,
uinode_rect.min.x + positions_diff[0].x * extracted_uinode.scale_factor,
uinode_rect.min.y + positions_diff[0].y * extracted_uinode.scale_factor,
),
Vec2::new(
uinode_rect.max.x + positions_diff[2].x,
uinode_rect.min.y - positions_diff[2].y,
uinode_rect.max.x + positions_diff[1].x * extracted_uinode.scale_factor,
uinode_rect.min.y + positions_diff[1].y * extracted_uinode.scale_factor,
),
Vec2::new(
uinode_rect.max.x + positions_diff[1].x,
uinode_rect.max.y - positions_diff[1].y,
uinode_rect.max.x + positions_diff[2].x * extracted_uinode.scale_factor,
uinode_rect.max.y + positions_diff[2].y * extracted_uinode.scale_factor,
),
Vec2::new(
uinode_rect.min.x + positions_diff[0].x,
uinode_rect.max.y - positions_diff[0].y,
uinode_rect.min.x + positions_diff[3].x * extracted_uinode.scale_factor,
uinode_rect.max.y + positions_diff[3].y * extracted_uinode.scale_factor,
),
]
.map(|pos| pos / atlas_extent);
Expand Down
4 changes: 3 additions & 1 deletion crates/bevy_ui/src/update.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ fn update_clipping(
commands.entity(entity).insert(CalculatedClip { clip });
}
(Some(clip), Some(mut old_clip)) => {
*old_clip = CalculatedClip { clip };
if old_clip.clip != clip {
*old_clip = CalculatedClip { clip };
}
}
}

Expand Down