Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Specialize UI pipeline on "hdr-ness" #6459

Closed
wants to merge 1 commit into from

Conversation

cart
Copy link
Member

@cart cart commented Nov 3, 2022

Objective

The UI pass in HDR breaks currently because the color attachment format does not match the HDR ViewTarget.

Solution

Specialize the UI pipeline on "hdr-ness" and select the appropriate format (like we do in the other built in pipelines).

@cart cart added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Nov 3, 2022
@cart cart added this to the Bevy 0.9 milestone Nov 3, 2022
@cart
Copy link
Member Author

cart commented Nov 3, 2022

bors r+

bors bot pushed a commit that referenced this pull request Nov 3, 2022
# Objective

The UI pass in HDR breaks currently because the color attachment format does not match the HDR ViewTarget.

## Solution

Specialize the UI pipeline on "hdr-ness" and select the appropriate format (like we do in the other built in pipelines).
@bors bors bot changed the title Specialize UI pipeline on "hdr-ness" [Merged by Bors] - Specialize UI pipeline on "hdr-ness" Nov 3, 2022
@bors bors bot closed this Nov 3, 2022
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
# Objective

The UI pass in HDR breaks currently because the color attachment format does not match the HDR ViewTarget.

## Solution

Specialize the UI pipeline on "hdr-ness" and select the appropriate format (like we do in the other built in pipelines).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants