Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - Reduce the use of atomics in the render phase #7084
[Merged by Bors] - Reduce the use of atomics in the render phase #7084
Changes from all commits
b411da6
702b2c4
2c099b1
8e4f9ff
45f227a
03d6ca3
22fd3c7
4a5638f
1a4083a
5efcff3
54cd232
1756709
aa146b3
68f4a36
4d4d9b4
c09c358
f63f670
d034b09
0a84aaa
592dd8e
ef78c5b
0a79eec
266583c
84a2d7f
b90341e
ce70df9
15b8527
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what way will the results be inaccurate? Is it just that any newly-added archetypes will be skipped? Not suggesting a change necessarily, just asking why this function is safe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New archetypes are ignored. Queries, for example, will just not return the target entity in those new archetypes. The prior archetypes are still accessed correctly, so this shouldn't cause any UB if not updated.