Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Use Ref instead of &T and Changed<T> #7175

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Use Ref instead of &T and Changed<T> #7175

wants to merge 1 commit into from

Conversation

james7132
Copy link
Member

Objective

Follow up #7097. Use Ref<T> instead of &T and the change detection query params.

Solution

Replace them.

@james7132 james7132 added A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change A-Transform Translations, rotations and scales labels Jan 12, 2023
alice-i-cecile
alice-i-cecile approved these changes Jan 12, 2023
View reviewed changes
Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Jan 12, 2023
bors bot pushed a commit that referenced this pull request Jan 12, 2023
@james7132
Use Ref instead of &T and Changed<T> (#7175)
b47c466 
# Objective
Follow up #7097. Use `Ref<T>` instead of `&T` and the change detection query params.

## Solution
Replace them.
@bors
Copy link
Contributor

bors bot commented Jan 12, 2023

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Use Ref instead of &T and Changed<T> [Merged by Bors] - Use Ref instead of &T and Changed<T> Jan 12, 2023
@bors bors bot closed this Jan 12, 2023
@james7132 james7132 deleted the use-ref-instead-of-changed branch January 20, 2023 01:11
alradish pushed a commit to alradish/bevy that referenced this pull request Jan 22, 2023
@james7132 @alradish
Use Ref instead of &T and Changed<T> (bevyengine#7175)
e540eff 
# Objective
Follow up bevyengine#7097. Use `Ref<T>` instead of `&T` and the change detection query params.

## Solution
Replace them.
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@james7132 @ItsDoot
Use Ref instead of &T and Changed<T> (bevyengine#7175)
0a3b635 
# Objective
Follow up bevyengine#7097. Use `Ref<T>` instead of `&T` and the change detection query params.

## Solution
Replace them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Assignees
No one assigned
Labels
A-Transform Translations, rotations and scales A-UI Graphical user interfaces, styles, layouts, and widgets C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@james7132 @alice-i-cecile @tim-blackbird