[Merged by Bors] - expose ambiguities of ScheduleGraph
#7716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
requested changes
Feb 16, 2023
james7132
added
A-ECS
|
Alternative: #7719 |
mockersf
reviewed
Feb 16, 2023
Comment on lines
+237
to
+241
| /// Returns a mutable reference to the [`ScheduleGraph`]. | ||
| pub fn graph_mut(&mut self) -> &mut ScheduleGraph { | ||
| &mut self.graph | ||
| } | ||
|
|
There was a problem hiding this comment.
It's needed to call build_schedule, otherwise you won't have the ambiguities
alice-i-cecile
added
the
S-Ready-For-Final-Review
bors bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
# Objective - other tools (bevy_mod_debugdump) would like to have access to the ambiguities so that they can do their own reporting/visualization ## Solution - store `conflicting_systems` in `ScheduleGraph` after calling `build_schedule` The solution isn't very pretty and as pointed out it #7522, there may be a better way of exposing this, but this is the quick and dirty way if we want to have this functionality exposed in 0.10.
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
ScheduleGraphScheduleGraph
bors bot
pushed a commit
that referenced
this pull request
Feb 17, 2023
follow-up to #7716 # Objective System access is only populated in `System::initialize`, so without calling `initialize` it's actually impossible to see most ambiguities. ## Solution - make `initialize` public. The method is idempotent, so calling it multiple times doesn't hurt
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 18, 2023
# Objective - other tools (bevy_mod_debugdump) would like to have access to the ambiguities so that they can do their own reporting/visualization ## Solution - store `conflicting_systems` in `ScheduleGraph` after calling `build_schedule` The solution isn't very pretty and as pointed out it bevyengine#7522, there may be a better way of exposing this, but this is the quick and dirty way if we want to have this functionality exposed in 0.10.
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 18, 2023
follow-up to bevyengine#7716 # Objective System access is only populated in `System::initialize`, so without calling `initialize` it's actually impossible to see most ambiguities. ## Solution - make `initialize` public. The method is idempotent, so calling it multiple times doesn't hurt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
conflicting_systemsinScheduleGraphafter callingbuild_scheduleThe solution isn't very pretty and as pointed out it #7522, there may be a better way of exposing this, but this is the quick and dirty way if we want to have this functionality exposed in 0.10.