Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FileAssetIo NotFound error to include full path #821

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

4-rodrigo-salazar
Copy link
Contributor

@4-rodrigo-salazar 4-rodrigo-salazar commented Nov 9, 2020

When learning bevy I ran into the issue loading an asset and I could not figure out where to place the asset in order for it to be found by "asset_server.load".

I believe multiple other people also have run into the same issues. Some people assume it should be rooted at the cargo project folder, some believe it might be rooted at the location of the built binary, but none expect that it's a folder called 'assets':

Examples of people potentially confused:
https://discordapp.com/channels/691052431525675048/742884593551802431/775146229880717322
Issue #810
https://discordapp.com/channels/691052431525675048/742884593551802431/775199619504144434

This updates FileAssetIo to include the full path in the error message, this will clearly flag to the developer that the game engine is looking for the assets specifically in this location. This should be enough information for people to resolve the issue by clarifying what the convention is.

@Moxinilian Moxinilian added A-Assets Load files from disk to use for things like images, models, and sounds C-Feature A new feature, making something new possible labels Nov 9, 2020
@cart cart merged commit 0c30762 into bevyengine:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Feature A new feature, making something new possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants