Fix desktop profiles which are crashing because of sync object id duplication #8358

AlexeyBarabash · 2020-02-21T18:38:56Z

Description

Related to #8325

Steps to Reproduce

Take browser version which does not have fix of Sync fix bookmarks object id duplication brave-core#4710
Go through STR of Duplicate sync object id of bookmarks #8325
Take the newest version and launch on that profile

Actual result:

Browser crashes

Expected result:

Browser should not crash

Reproduces how often:

Easily

AlexeyBarabash · 2020-03-11T11:09:49Z

Tested on Nightly installer 1.8.2 and the profile I created with duplicated bookmarks before brave/brave-core#4710 fix. I could run browser without the crash.

bsclifton · 2020-03-11T17:45:29Z

Added missing milestone to both this issue and the PR that closed it 👍

fmarier · 2020-03-11T21:21:48Z

I tested this with my cursed profile and got a crash as soon as I enabled Sync. Here are the two crash IDs I got on the console:

68e8c1340e85e1c4
5695c488f069731d

Brave	1.8.3 Chromium: 80.0.3987.132 (Official Build) nightly (64-bit)
Revision	fcea73228632975e052eb90fcf6cd1752d3b42b4-refs/branch-heads/3987@{#974}
OS	Linux

The exact steps I followed were:

Update brave-browser-nightly.
Start using brave-browser-nightly --user-data-dir=/home/francois/BraveTemp.
Go into brave://flags and enable "Brave Sync".
Click "Relaunch".
Go in to brave://sync and click on the toggle to enable syncing of Bookmarks.

fmarier · 2020-03-12T21:15:20Z

Here's my Bookmarks file which reproduces the crash every time:

{
   "checksum": "9e4424460f25605e390d843c12cd458d",
   "roots": {
      "bookmark_bar": {
         "children": [ {
            "date_added": "13228434827067422",
            "guid": "27ff03a7-5059-4027-811a-4d957fe9f99c",
            "id": "1142",
            "meta_info": {
               "object_id": "132, 253, 161, 194, 6, 242, 230, 175, 199, 140, 98, 79, 67, 224, 235, 109",
               "order": "1.0.1.1.1.48.17.17.1.1.2.13.7.7.1.3.7.3.5.14.7.11.5.1.4.4.5.2.4.15.21.5.2.1.41.0.1",
               "originator_cache_guid": "DN9zzqXH8hpFBZX8jnqE2A==",
               "originator_client_item_id": "963ea23b-796b-4ab7-ba8b-2da08f89c39a",
               "parent_object_id": "175, 162, 9, 69, 152, 241, 30, 1, 1, 54, 199, 130, 135, 245, 231, 210",
               "position_in_parent": "9223372036844506714",
               "sync_timestamp": "1583961227067.509033"
            },
            "name": "Seared Albacore Tuna Recipe - YouTube",
            "type": "url",
            "url": "https://www.youtube.com/watch?v=sv3f7hZWIag&__s=zcraatsjbtesssn2kiyk"
         }, {
            "date_added": "0",
            "guid": "86eb7708-6ebc-472e-a242-c2543d9de769",
            "id": "1062",
            "meta_info": {
               "object_id": "81, 241, 29, 222, 16, 67, 121, 169, 186, 35, 107, 160, 55, 103, 235, 150",
               "order": "1.0.1.1.1.48.17.17.1.1.2.13.7.7.1.3.7.3.5.14.7.11.5.1.4.4.5.2.4.15.21.5.2.1.41.0.3",
               "originator_cache_guid": "DN9zzqXH8hpFBZX8jnqE2A==",
               "originator_client_item_id": "963ea23b-796b-4ab7-ba8b-2da08f89c39a",
               "parent_object_id": "175, 162, 9, 69, 152, 241, 30, 1, 1, 54, 199, 130, 135, 245, 231, 210",
               "position_in_parent": "9223372036758780229",
               "sync_timestamp": "1571717780003.000000",
               "version": "2"
            },
            "name": "Seared Albacore Tuna Recipe - YouTube",
            "sync_transaction_version": "3",
            "type": "url",
            "url": "https://www.youtube.com/watch?v=sv3f7hZWIag&__s=zcraatsjbtesssn2kiyk"
         }, {
            "date_added": "0",
            "guid": "a042c7da-50e8-46a0-868f-9e82304f2f37",
            "id": "1060",
            "meta_info": {
               "object_id": "81, 241, 29, 222, 16, 67, 121, 169, 186, 35, 107, 160, 55, 103, 235, 150",
               "order": "1.0.1.1.1.48.17.17.1.1.2.13.7.7.1.3.7.3.5.14.7.11.5.1.4.4.5.2.4.15.21.5.2.1.41.1",
               "originator_cache_guid": "DN9zzqXH8hpFBZX8jnqE2A==",
               "originator_client_item_id": "963ea23b-796b-4ab7-ba8b-2da08f89c39a",
               "parent_object_id": "175, 162, 9, 69, 152, 241, 30, 1, 1, 54, 199, 130, 135, 245, 231, 210",
               "position_in_parent": "9223372036844506714",
               "sync_timestamp": "1572212355279.000000",
               "version": "2"
            },
            "name": "Seared Albacore Tuna Recipe - YouTube",
            "sync_transaction_version": "7",
            "type": "url",
            "url": "https://www.youtube.com/watch?v=sv3f7hZWIag&__s=zcraatsjbtesssn2kiyk"
         } ],
         "date_added": "13198965811090893",
         "date_modified": "13228520759621761",
         "guid": "00000000-0000-4000-A000-000000000002",
         "id": "1",
         "meta_info": {
            "order": "1.1.1"
         },
         "name": "Favoris",
         "sync_transaction_version": "3",
         "type": "folder"
      },
      "other": {
         "children": [  ],
         "date_added": "13198965811090899",
         "date_modified": "13228434827066320",
         "guid": "00000000-0000-4000-A000-000000000003",
         "id": "2",
         "meta_info": {
            "order": "1.1.2"
         },
         "name": "Other bookmarks",
         "sync_transaction_version": "3",
         "type": "folder"
      },
      "sync_transaction_version": "75",
      "synced": {
         "children": [  ],
         "date_added": "13198965811090900",
         "date_modified": "0",
         "guid": "00000000-0000-4000-A000-000000000004",
         "id": "3",
         "name": "Mobile bookmarks",
         "sync_transaction_version": "3",
         "type": "folder"
      }
   },
   "version": 1
}

AlexeyBarabash · 2020-03-27T08:54:17Z

After merging brave/brave-core#4940 , we found the fix does not work for 2 of 3 of @fmarier devices, so re-opening

btlechowski · 2020-04-13T07:23:08Z

Verification passed on

Brave	1.7.92 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision	e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#5139

Steps used

Install 1.3.118
Go to about:flags#brave-sync and enable sync
Create a sync chain
Go to brave://bookmarks/
Add a bookmark
Exit browser
Copy content of Fix desktop profiles which are crashing because of sync object id duplication #8358 (comment) to Bookmarks file
Upgrade to 1.7.92

Reproduced the crash after upgrade to 1.7.90
Verified no crash after upgrade to 1.7.92

Test case - disabled sync

Install 1.3.118
Go to about:flags#brave-sync and enable sync
Create a sync chain
Go to brave://bookmarks/
Add a bookmark
Exit browser
Copy content of Fix desktop profiles which are crashing because of sync object id duplication #8358 (comment) to Bookmarks file
Upgrade to 1.9.15
Run brave with flag --disable-sync

Verified no crash after upgrade to 1.7.92

Verification passed on

Brave	1.7.92 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision	e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Verified test plan from Sync duplicated object id migration (3) brave-core#5139

Steps used

Install 1.3.118
Go to about:flags#brave-sync and enable sync
Create a sync chain
Go to brave://bookmarks/
Add a bookmark
Exit browser
Copy content of Fix desktop profiles which are crashing because of sync object id duplication #8358 (comment) to Bookmarks file
Upgrade to 1.7.90
Reproduced the crash after upgrade to 1.7.90
Upgrade to 1.7.92
Verified no crash after upgrade to 1.7.92

Verified that bookmarks can be added/edited/deleted after upgrade to 1.7.92

Verified passed with

Brave	1.7.92 Chromium: 80.0.3987.163 (Official Build) (64-bit)
Revision	e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS	macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#5139

Steps used

Install 1.3.118
Go to about:flags#brave-sync and enable sync
Create a sync chain
Go to brave://bookmarks/
Add a bookmark
Exit browser
Copy content of Fix desktop profiles which are crashing because of sync object id duplication #8358 (comment) to Bookmarks file
Upgrade to 1.7.92

Reproduced the crash after upgrade to 1.7.90
Verified no crash after upgrade to 1.7.92 - Note, I did have to force quit my first launch of 1.7.92 for this case.

Test case - disabled sync

Install 1.3.118
Go to about:flags#brave-sync and enable sync
Create a sync chain
Go to brave://bookmarks/
Add a bookmark
Exit browser
Copy content of Fix desktop profiles which are crashing because of sync object id duplication #8358 (comment) to Bookmarks file
Upgrade to 1.9.15
Run brave with flag --disable-sync

Verified no crash after upgrade to 1.7.92

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave | 1.7.92 Chromium: 80.0.3987.163 (Official Build) (64-bit)
-- | --
Revision | e7fbe071abe9328cdce4ffedac9822435fbd3656-refs/branch-heads/3987@{#1037}
OS | macOS Version 10.15.3 (Build 19D76)

Verified test plan from brave/brave-core#5139

Test Case #1

Install 1.3.118
Go to about:flags#brave-sync and enable sync
Create a sync chain
Go to brave://bookmarks/
Add a bookmark
Exit browser
Copy content of Fix desktop profiles which are crashing because of sync object id duplication #8358 (comment) to Bookmarks file
Upgrade to 1.7.92

Reproduced the crash after upgrade to 1.7.90
Verified no crash after upgrade to 1.7.92

Test Case #2 - using --disable-sync

Install 1.3.118
Go to about:flags#brave-sync and enable sync
Create a sync chain
Go to brave://bookmarks/
Add a bookmark
Exit browser
Copy content of Fix desktop profiles which are crashing because of sync object id duplication #8358 (comment) to Bookmarks file
Upgrade to 1.9.15
Run brave with flag --disable-sync

Verified no crash after upgrade to 1.7.92

AlexeyBarabash added crash feature/sync labels Feb 21, 2020

AlexeyBarabash mentioned this issue Feb 21, 2020

Sync fix bookmarks object id duplication brave/brave-core#4710

Merged

32 tasks

AlexeyBarabash mentioned this issue Mar 3, 2020

Recreating bookmarks with duplicated sync object id brave/brave-core#4816

Merged

32 tasks

GeetaSarvadnya mentioned this issue Mar 4, 2020

Duplicate sync object id of bookmarks #8325

Closed

AlexeyBarabash added the QA/Yes label Mar 5, 2020

AlexeyBarabash closed this as completed in brave/brave-core#4816 Mar 10, 2020

bsclifton added this to the 1.7.x - Beta milestone Mar 11, 2020

bsclifton added the release-notes/include label Mar 11, 2020

fmarier reopened this Mar 11, 2020

AlexeyBarabash removed this from the 1.7.x - Beta milestone Mar 11, 2020

AlexeyBarabash mentioned this issue Mar 13, 2020

Migration of duplicated bookmarks for sync (2) brave/brave-core#4940

Merged

32 tasks

AlexeyBarabash closed this as completed in brave/brave-core#4940 Mar 25, 2020

AlexeyBarabash added this to the 1.8.x - Nightly milestone Mar 25, 2020

AlexeyBarabash reopened this Mar 27, 2020

AlexeyBarabash mentioned this issue Apr 1, 2020

Sync duplicated object id migration (3) brave/brave-core#5139

Merged

32 tasks

bsclifton modified the milestones: 1.8.x - Beta, 1.9.x - Nightly Apr 9, 2020

This was referenced Apr 9, 2020

Sync duplicated object id migration fixes (uplift to 1.7.x) brave/brave-core#5212

Merged

Sync duplicated object id migration fixes (uplift to 1.8.x) brave/brave-core#5213

Merged

bsclifton closed this as completed in brave/brave-core#5139 Apr 10, 2020

bsclifton assigned AlexeyBarabash Apr 10, 2020

bsclifton removed this from the 1.9.x - Nightly milestone Apr 11, 2020

bsclifton modified the milestones: 1.7.x - Release Hotfix 1, 1.7.x - Release Apr 11, 2020

btlechowski added the QA Pass-Linux label Apr 13, 2020

GeetaSarvadnya added the QA Pass-Win64 label Apr 13, 2020

kjozwiak added the QA Pass-macOS label Apr 14, 2020

kjozwiak mentioned this issue Apr 14, 2020

Release Notes for 1.7.x (Release Channel) #9109

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix desktop profiles which are crashing because of sync object id duplication #8358

Fix desktop profiles which are crashing because of sync object id duplication #8358

AlexeyBarabash commented Feb 21, 2020

AlexeyBarabash commented Mar 11, 2020

bsclifton commented Mar 11, 2020

fmarier commented Mar 11, 2020 •

edited

Loading

fmarier commented Mar 12, 2020

AlexeyBarabash commented Mar 27, 2020

btlechowski commented Apr 13, 2020 •

edited by kjozwiak

Loading

Fix desktop profiles which are crashing because of sync object id duplication #8358

Fix desktop profiles which are crashing because of sync object id duplication #8358

Comments

AlexeyBarabash commented Feb 21, 2020

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

AlexeyBarabash commented Mar 11, 2020

bsclifton commented Mar 11, 2020

fmarier commented Mar 11, 2020 • edited Loading

fmarier commented Mar 12, 2020

AlexeyBarabash commented Mar 27, 2020

btlechowski commented Apr 13, 2020 • edited by kjozwiak Loading

fmarier commented Mar 11, 2020 •

edited

Loading

btlechowski commented Apr 13, 2020 •

edited by kjozwiak

Loading