Migration of duplicated bookmarks for sync (2)

[AlexeyBarabash]

consider creation time can be equal; fixes brave-browser#8358

Resolves brave/brave-browser#8358

Submitter Checklist:

• Submitted a ticket for my issue if one did not already exist.
• Used Github auto-closing keywords in the commit message.
• Added/updated tests for this change (for new code or code which already has tests).
• Verified that these changes build without errors on
  • Android
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that these changes pass automated tests (unit, browser, security tests) on
  • iOS
  • Linux
  • macOS
  • Windows
• Verified that all lint errors/warnings are resolved (npm run lint)
• Ran git rebase master (if needed).
• Ran git rebase -i to squash commits (if needed).
• Tagged reviewers and labelled the pull request as needed.
• Request a security/privacy review as needed.
• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
• Public documentation has been updated as necessary. For instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-compatibility-issues-with-tracking-protection
  • https://github.com/brave/brave-browser/wiki/QA-Guide

Test Plan:

I. Test of object id migration

1. Build browser without bookmarks metainfo fix and without object_id migration

2. Enable sync on devices A and B

3. Create sync chain between devices A and B

4. On device A create bookmarks A.com, AA.com, AAA.com; wait until they will not appear on device B

5. Disable sync through flags on device A

6. Restart browser on device A

7. On device A select 3 bookmarks, copy and paste them 3 times: before original, inside original and after original

8. Enable sync through flags on device A

9. Close browser device A

10. Build browser with bookmarks metainfo fix and with object_id migration

11. Open browser device B

12. Order of bookmarks between A and B must be the same. It takes 10 minutes for changes to appear on device B because of resend.

For step 14 need to wait 10 minutes, because 1st attempt of send updates fails because js lib is not yet initialized, so actual send happens during re-send procedure.

II. Test to ensure orders are ok if bookmarks are moved when sync is off

1. Create sync chain between A and B
2. Create on device A these bookmarks on following order:

A1.com
A2.com
A3.com
A4.com

3. Wait till they would be be synced to device B
4. Disable sync on device A
5. Arrange bookmarks on device A as:

A4.com
A2.com
A1.com
A3.com

6. Enable sync on device A
7. Expected/Actual: device B to have bookmarks in the same order.

For step 7 need to wait 10 minutes, because 1st attempt of send updates fails because js lib is not yet initialized, so actual send happens during re-send procedure.

Reviewer Checklist:

• New files have MPL-2.0 license header.
• Request a security/privacy review as needed.
• Adequate test coverage exists to prevent regressions
• Verify test plan is specified in PR before merging to source

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on.
• All relevant documentation has been updated.

[AlexeyBarabash]

PR is in progress.
I made it now to get CI - built for Linux deb packages to try it on @fmarier profile.

This PR still needs to

1. Update testcases for duplicated bookmarks which have equal ctime
2. Add migration and test for broken bookmarks orders

cc @jsecretan

[AlexeyBarabash]

CI failed because fetched wrong chromium, 80.0.3987.132 instead of 80.0.3987.149, removed b-b and restarted

[AlexeyBarabash]

This PR was tested on profile of @fmarier , which crashed with previous attempt of fix (#4816).

[darkdh]

lgtm now

[AlexeyBarabash]

@fmarier verified the last change works good on his broken profile.

CI failed because I didn't update test. Now it is updated. Removed all CI-skip-xxxx labels.

[AlexeyBarabash]

macOS build failed with weird error

11:08:00  ../../chrome/common/chrome_content_client.h:17:10: fatal error: 'chrome/common/buildflags.h' file not found
11:08:00  #include "chrome/common/buildflags.h"
11:08:00           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

All other is green: https://ci.brave.com/job/brave-browser-build-pr/job/sync_dup_obj_id_migration2/ .
Skipping all except macOS and restarting.

[AlexeyBarabash]

CI completed with status UNSTABLE
Failed browser-test on macOS

14:41:12  [511/511] BraveRewardsBrowserTest.TipConnectedPublisherAnonAndConnected (TIMED OUT)
14:41:12  1 test timed out:
14:41:12      BraveRewardsBrowserTest.TipConnectedPublisherAnonAndConnected (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2762)

[AlexeyBarabash]

The same error

16:48:22  [511/511] BraveRewardsBrowserTest.TipConnectedPublisherAnonAndConnected (TIMED OUT)
16:48:22  1 test timed out:
16:48:22      BraveRewardsBrowserTest.TipConnectedPublisherAnonAndConnected (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2762)

[AlexeyBarabash]

Removed b-b branch and rebased to get another try with CI.