Sync duplicated object id migration fixes (uplift to 1.7.x) #5212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migration of duplicated bookmarks for sync (2)
…icated folders; fixes brave-browser#8358
…ding nested in duplicated folders
- Prevents brave/brave-browser#9110 (or similar) from happening - Added unit test to ensure migration not done if sync disabled
|
Travis-CI shows as failure because we didn't uplift the npm vulnerability fixes. JavaScript unit tests and all other checks passed just fine on Travis-CI check 😄 |
|
CI passed great on Android/Linux/Windows. Timed out on macOS/iOS. Going to restart |
LaurenWags
approved these changes
Apr 11, 2020
There was a problem hiding this comment.
++
Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.
Travis failed due to known issue brave/brave-browser#8722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual uplift of #4940 and #5139
Fixes brave/brave-browser#8358
Fixes brave/brave-browser#9110
Approved, please ensure that before merging:
After you merge: