Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a list of fall-back engines to try for private window search #3672

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Have a list of fall-back engines to try for private window search #3672

merged 1 commit into from
Oct 11, 2019

Commits on Oct 11, 2019

  1. Have a list of fall-back engines to try for private window search 

    Fixes brave/brave-browser#6421

Problem was regular DDG not found in the entries returned (since locale specific was returned instead).
Besides adding other entries, this also puts a dcheck in place to ensure an engine gets set (otherwise, the error thrown is no immediately clear and a bit hard to trace).

(bug unintentionally introduced with #3591)
    @bsclifton
    bsclifton committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    eab3d1c View commit details
    Browse the repository at this point in the history