Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a list of fall-back engines to try for private window search #3672

Merged
merged 1 commit into from
Oct 11, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Oct 11, 2019

Fixes brave/brave-browser#6421

Problem was regular DDG not found in the entries returned (since locale specific was returned instead).

Besides adding other entries, this also puts a dcheck in place to ensure an engine gets set (otherwise, the error thrown is no immediately clear and a bit hard to trace).

(bug unintentionally introduced with #3591)

Submitter Checklist:

Test Plan:

See brave/brave-browser#6421

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

simonhong
simonhong previously approved these changes Oct 11, 2019
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Using do-while or range for-loop depends on your preference :)

Fixes brave/brave-browser#6421

Problem was regular DDG not found in the entries returned (since locale specific was returned instead).
Besides adding other entries, this also puts a dcheck in place to ensure an engine gets set (otherwise, the error thrown is no immediately clear and a bit hard to trace).

(bug unintentionally introduced with #3591)
@bsclifton
Copy link
Member Author

Lint has failures which are unrelated to this PR - but otherwise, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser crash when new private window is opened in German locale
3 participants