Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have a list of fall-back engines to try for private window search (uplift to 0.70.x) #3680

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Have a list of fall-back engines to try for private window search (uplift to 0.70.x) #3680

merged 1 commit into from
Oct 14, 2019

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Oct 11, 2019 •
edited by bsclifton
Loading

Uplift of #3672
Fixes brave/brave-browser#6421

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Oct 11, 2019
@brave-builds brave-builds added this to the 0.70.x - Beta milestone Oct 11, 2019
@bsclifton bsclifton requested review from a team and removed request for bbondy, kjozwiak, bsclifton, rebron and srirambv October 11, 2019 16:05
bsclifton
bsclifton approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit 90e0303 into 0.70.x Oct 14, 2019
@bsclifton bsclifton deleted the pr3672_bsc-fix-incognito-search_0.70.x branch October 14, 2019 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
0.70.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @bsclifton @brave-browser-releases