Upgrade from Chromium 93 to Chromium 94. #9558

….4583.0.

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/013c362eb20bf785895d3114c29d40ea22aa2b95 commit 013c362eb20bf785895d3114c29d40ea22aa2b95 Author: dpapad <dpapad@chromium.org> Date: Wed Jul 21 16:39:13 2021 +0000 Profile Picker: Migrate to TypeScript. Bug: 1189595

Our patch is no longer needed as it was just short circuiting the upstream code which is now gone. Chromium change: https://source.chromium.org/chromium/chromium/src/+/6b474635934211fb22a847a10e6eb8f65d74f1d0 commit 6b474635934211fb22a847a10e6eb8f65d74f1d0 Author: Richard Knoll <knollr@chromium.org> Date: Mon Jul 19 11:02:04 2021 +0000 Remove NotificationsViaHelperApp flag and XPC code This cleans up the enabled-by-default flag to use the new macOS Notification mojo service instead of an XPC service. As we're no longer using the XPC service it can now be removed from our bundle. A follow up can remove the abstraction layers that were required to support both XPC and mojo implementations which will allow us to completely remove //chrome/browser/ui/cocoa/notifications. Bug: 1170731

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/07a1f39a7dc50df8861e71c6c8865ab437b22973 commit 07a1f39a7dc50df8861e71c6c8865ab437b22973 Author: Song Fangzhen <songfangzhen@bytedance.com> Date: Tue Jul 20 22:05:59 2021 +0000 Reland "DPWA: Merge web_applications/components/BUILD.gn into web_applications/BUILD.gn" This is a reland of e63e401a3f2942864983de094c2b74f5810146c2 The issue is fixed through moving .cc/.h entries from web_applications/preinstalled_web_apps/BUILD.gn to web_applications/BUILD.gn without moving actual files (no git mv). So now this CL can be landed. Aside, `gn check` has been tested locally and it passed. Original change's description: > DPWA: Merge web_applications/components/BUILD.gn into web_applications/BUILD.gn > > This CL moves .cc/.h entries from web_applications/components/BUILD.gn > to web_applications/BUILD.gn without moving actual files (no git mv). > > Bug: 1225132

Chromium change: https://source.chromium.org/chromium/chromium/src/+/486e9d58c0980be0d50054064e0b7d79446de071 commit 486e9d58c0980be0d50054064e0b7d79446de071 Author: Peter Kasting <pkasting@chromium.org> Date: Fri Jul 16 17:36:19 2021 +0000 Rename fieldtrial_testing_like_official_build GN flag. This flag name is confusing. Name it disable_fieldtrial_testing_config, which is what it actually does. Bug: 1154841

Chromium change: https://source.chromium.org/chromium/chromium/src/+/5327d8b59d2550161c49f7180cb05b1afbbea609 commit 5327d8b59d2550161c49f7180cb05b1afbbea609 Author: Bret Sepulveda <bsep@chromium.org> Date: Wed Jul 21 17:44:23 2021 +0000 Delete PermissionRequestImpl. This patch deletes PermissionRequestImpl, making PermissionRequest a concrete class with all of its functionality. PermissionRequest also now takes a RequestType rather than a ContentSettingsType, which allows it to support request types that don't have an associated ContentSettingsType (e.g. multiple downloads). Common functionality among the children of PermissionRequest is moved to the parent class. Bug: 1110905

Chromium change: https://source.chromium.org/chromium/chromium/src/+/30a878c4c52a2f2fb39c3cc822b07662b2fad1a3 commit 30a878c4c52a2f2fb39c3cc822b07662b2fad1a3 Author: Matt Menke <mmenke@chromium.org> Date: Tue Jul 20 22:25:09 2021 +0000 Move HttpNetworkSession::Context and ::Params out of HttpNetworkSession. They're now HttpNetworkSessionContext and HttpNetworkSessionParams (defined in the same file). This allows url_request_context.h to forward declare them, instead of including HttpNetworkSession. According to analyze_includes.py (https://commondatastorage.googleapis.com/chromium-browser-clang/include-analysis.html), that include was responsible for 0.06% of Chrome's translation unit bytes. Also fix some IWYU fallout from URLRequestContext not including HttpNetworkSession and related headers. Bug: 1227131

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/1268a99 commit 1268a999c4a953d7e2b2c26bf9fa019e38ee0504 Author: Victor Costan <pwnall@chromium.org> Date: Fri Jul 16 17:16:39 2021 +0000 sql: Change the Statement::ColumnBlob() return type to base::span. ColumnBlob() currently returns a pointer to a data buffer, which must be paired with the return result of ColumnByteLength(). This made sense when the code was written, but we have safer and more ergonomic alternatives now. This CL switches the return type to base::span<const uint8_t>, which is the closest reflection of the fact that BLOBs are arrays of bytes. sql::Statement still has helpers for retrieving BLOB data as std::string and std::vector<char> / std::vector<uint8_t>. Bug: 1229451

Chromium change: https://source.chromium.org/chromium/chromium/src/+/496ac2849b59e4f04c099b6d9b0f0ad823ebae99 commit 496ac2849b59e4f04c099b6d9b0f0ad823ebae99 Author: Dana Fried <dfried@chromium.org> Date: Wed Jul 21 21:13:51 2021 +0000 Combine title/domain labels and fade-out labels into single views. Creates the new FadeLabel class, local to TabHoverCardBubbleView, which provides the text-fade-out functionality by rendering one transparent label over another. This simplifies layout calculations greatly, and mirrors what we've done with the ThumbnailView class (also private to that module). This change helps ensure that changes we're making in the alternate hover card layout don't result in bad visuals when cards move around, especially when the active tab is selected and the hover card image disappears. Bug: 1222987

Chromium change: https://source.chromium.org/chromium/chromium/src/+/09a28ea4051160db33c621c202600d086dce4840 commit 09a28ea4051160db33c621c202600d086dce4840 Author: Alex Cooper <alcooper@chromium.org> Date: Mon Jul 19 23:10:30 2021 +0000 [CodeHealth] Remove ListValue::GetInteger Now that all usages of ListValue::GetInteger have been removed from the code base, this deprecated method (and it's usage in the UnitTests), can be removed. Fixed: 1187087

Chromium change: https://bugs.chromium.org/p/chromium/issues/detail?id=1223264 https://chromium.googlesource.com/chromium/src/+/7c683fe7de2aaff98f1ac8f0c2a24d2a44635499 commit 7c683fe7de2aaff98f1ac8f0c2a24d2a44635499 Author: Peter Kasting <pkasting@chromium.org> Date: Thu Jun 24 15:12:10 2021 +0000 Fix -Wloop-analysis warnings in chrome/. These indicate when a range-based for loop is using an index whose type (value, pointer, or reference) doesn't match what the loop actually extracts from the range. Fix by matching the actual type better. This shouldn't cause any behavior/performance change, just be slightly clearer about what's actually happening when reading the code. Bug: 1223264

Switched to checking for is_type_normal for this particular use. Chromium changes: https://source.chromium.org/chromium/chromium/src/+/2f6b1ffb19c9567963ce3978c1ca934cf6cb1b9c commit 2f6b1ffb19c9567963ce3978c1ca934cf6cb1b9c Author: Joel Hockey <joelhockey@chromium.org> Date: Mon Jul 19 22:14:11 2021 +0000 Remove Browser::deprecated_is_app() All callsites now removed. Bug: 990158 https://chromium.googlesource.com/chromium/src.git/+/2687ab53d96be061473d170ee88060b59067cd66 commit 2687ab53d96be061473d170ee88060b59067cd66 Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Aug 14 23:59:46 2019 +0000 Refactor Browser::Type Change from {TABBED, POPUP}, to {NORMAL, POPUP, APP, DEVTOOLS} Browser::is_type_tabbed() => Browser::is_type_normal() Browser::is_type_popup() (used to include POPUP, APP, DEVTOOLS) split into: * Browser::is_type_popup() * Browser::is_type_app() * Browser::is_type_devtools() Browser::is_app() => Browser::deprecated_is_app() (APP or DEVTOOLS) and also split into: * Browser::is_type_app() * Browser::is_type_devtools() This is quite a large change, but there is hopefully no or very little change to any logic. To help reviewers, I have uploaded 10 different patchsets which each perform a small refactoring change that make up this CL. Patchset 12: s/TYPE_TABBED/TYPE_NORMAL/ Patchset 13: s/kMatchTabbed/kMatchNormal/ Patchset 14: s/is_type_tabbed/is_type_normal/ Patchset 15: s/is_devtools/is_type_devtools/ Patchset 16: s/is_app/deprecated_is_app/ Patchset 17: s/is_type_popup/!is_type_normal/ Patchset 18: Add TYPE_APP and TYPE_DEVTOOLS (main change) Patchset 19: SyncedWindowDelegate Patchset 20: little fixes, git cl format Patchset 21: Fix types in tests Patchset 18 is the only one that has any change to non-test code which is not a pure refactor. Bug: 990158

Chromium change: https://source.chromium.org/chromium/chromium/src/+/205b96dc46df217db695fed5eb7d00844b145870 commit 205b96dc46df217db695fed5eb7d00844b145870 Author: Victor Costan <pwnall@chromium.org> Date: Wed Jul 21 20:27:46 2021 +0000 sql: Make Database::ExecuteAndReturnErrorCode() private. The Database::Execute() guidance currently points to ExecuteAndReturnErrorCode() for situations where errors would be ignored. However, the guidance is ignored [1, 2], and ExecuteAndReturnErrorCode() is not used outside of //sql. This CL makes ExecuteAndReturnErrorCode() private to Database, and updates testing code that relied on it. This is an architectural improvement, as code outside //sql should not have to know about SQLite error codes. [1] https://source.chromium.org/search?q=ignore_result%5C(.*%5C.Execute%5C( [2] https://source.chromium.org/search?q=ignore_result%5C(.*-%3EExecute%5C(

Chromium change: https://source.chromium.org/chromium/chromium/src/+/a5400731f7ac9251e6e383c0c176aa559db7ec68 commit a5400731f7ac9251e6e383c0c176aa559db7ec68 Author: Greg Thompson <grt@chromium.org> Date: Tue Jul 20 20:40:50 2021 +0000 install_static::ChannelStrategy branding cleanup. Make the values in the enum install_static::ChannelStrategy conditional on the branding. The meaning of the values are branding-specific, so it makes sense that the values themselves are, too. This is pure cleanup with no change in behavior. Bug: 1229222

Our overrides of this type of tests does no longer compile due to the latest changes upstream, unveiling that our TabHoverCardBubbleViewBrowserTest override has become quite out-of-date compared to the one upstream, so let's make the most of this occasion to bring it up to date with upstream's. Chromium changes: https://source.chromium.org/chromium/chromium/src/+/496ac2849b59e4f04c099b6d9b0f0ad823ebae99 https://source.chromium.org/chromium/chromium/src/+/ab4d107aabf21191cfa2da75334bb6bbe463ee6e https://source.chromium.org/chromium/chromium/src/+/2c470ea5c9ece4f1c385b159e169566b2dcc434e https://source.chromium.org/chromium/chromium/src/+/c050a3f62911afe95885e1840e7ffcfe837a523e https://source.chromium.org/chromium/chromium/src/+/fec2af5a3312062439bc8a97baabdf97fc2ad924 https://source.chromium.org/chromium/chromium/src/+/e2124a1d261f70ffe0048553b0f4642e0444d6a1 https://source.chromium.org/chromium/chromium/src/+/dc5e8308d136551b4b96cd575997e9fcf8541a35 https://source.chromium.org/chromium/chromium/src/+/1f24ab638760a2d965b02c152442bb92edb7b8fa https://source.chromium.org/chromium/chromium/src/+/82700410f1c6a350e94858e0cf6d1f44e96dbad3 https://source.chromium.org/chromium/chromium/src/+/6f281bcc104374e5ddd4f8268d7155a84a9fa078 https://source.chromium.org/chromium/chromium/src/+/919ce657e4e37dfa13758f1eb8fe0e9ef7ab1b20 https://source.chromium.org/chromium/chromium/src/+/0ff4b9c05117390777ee54a1079085321919fb29 https://source.chromium.org/chromium/chromium/src/+/4d6086e6dc1c32eb35116a57ca2e7241181ce770 https://source.chromium.org/chromium/chromium/src/+/3074c550a2fabdef0036540699226a0babcea2b8 https://source.chromium.org/chromium/chromium/src/+/49bf6e021eb90a3486d2b1ccac933a071b755b8a https://source.chromium.org/chromium/chromium/src/+/3074c550a2fabdef0036540699226a0babcea2b8 commit 496ac2849b59e4f04c099b6d9b0f0ad823ebae99 Author: Dana Fried <dfried@chromium.org> Date: Wed Jul 21 21:13:51 2021 +0000 Combine title/domain labels and fade-out labels into single views. Creates the new FadeLabel class, local to TabHoverCardBubbleView, which provides the text-fade-out functionality by rendering one transparent label over another. This simplifies layout calculations greatly, and mirrors what we've done with the ThumbnailView class (also private to that module). This change helps ensure that changes we're making in the alternate hover card layout don't result in bad visuals when cards move around, especially when the active tab is selected and the hover card image disappears. Bug: 1222987 Change-Id: I960983f7789deb8c8f780a471b0d9c6fb896af3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3040324 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#904053} commit ab4d107aabf21191cfa2da75334bb6bbe463ee6e Author: Jan Wilken Dörrie <jdoerrie@chromium.org> Date: Tue Mar 23 18:47:42 2021 +0000 [LSC] Remove base::ASCIIToUTF16("...") in //chrome/browser/ui This change removes calls to base::ASCIIToUTF16 in //chrome/browser/ui with a single-line string literal and replaces them with a u"..." literal instead. Files where this change would cause compilation errors were not changed. This is a mechanical change: $ git grep -lw ASCIIToUTF16 chrome/browser/ui | xargs \ sed -i 's/$base::$\?ASCIIToUTF16($"\(\\.\|[^\\"]$*"\))/u\2/g' $ git cl format Bug: 1189439 Change-Id: Ia2f17f2dceeade756866222515c75a3271d2395b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2780082 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Owners-Override: danakj <danakj@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#865734} commit 2c470ea5c9ece4f1c385b159e169566b2dcc434e Author: Jan Wilken Dörrie <jdoerrie@chromium.org> Date: Mon Mar 22 22:26:24 2021 +0000 [LSC] Remove UTF8ToUTF16 from Literals without Escape Sequences This change removes calls to base::UTF8ToUTF16 with a single-line string literal not containing escape sequences and replaces them with a u"..." literal instead. This is a mechanical change: $ git grep -lw UTF8ToUTF16 | \ xargs sed -i 's/$base::$\?UTF8ToUTF16($"[^\\"]*"$)/u\2/g' $ git cl format AX-Relnotes: n/a. Bug: 1189439 Change-Id: I6df2e531f62926a12be3f610ce8627d94ec407f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2776021 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Owners-Override: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#865390} commit c050a3f62911afe95885e1840e7ffcfe837a523e Author: Dana Fried <dfried@chromium.org> Date: Mon Mar 22 19:32:47 2021 +0000 Add hover card metrics and move metric collection to a separate class. These changes are required in order to see how different optimizations including hover card preview delay affect the user experience and usage of hover cards. This CL does several things: - moves and centralized metric collection for hover cards into TabHoverCardMetrics - fixes several metrics to key off of a tab hover card being fully visible on the target tab, rather than just when the user hovers the tab for the first time (this will potentially change the histograms for these metrics but we feel it is an improvement): * TabHoverCards.TabHoverCardsSeenBeforeTabSelection * TabHoverCards.TimeSinceLastVisible - adds several metrics: * TabHoverCards.TabPreviewsSeenBeforeTabSelection is like hover cards seen, but counts preview images the user has viewed instead * TabHoverCards.TabHoverCardViewedTime records the amount of time a user sees a fully-faded-in, anchored hover card on a tab they are hovering. * TabHoverCards.TabPreviewViewedTime, which is like the above but for the amount of time they see a preview image. * TabHoverCards.LastTabHoverCardViewedTime, which is like the above, but only for the final tab the user selects (may be zero if the selection happens before the hover card fully fades/slides). * TabHoverCards.LastTabPreviewViewedTime, as above but for the final preview image, with the same caveats. All of the above except for TimeSinceLastVisible are bucketed by number of open tabs. A follow-up with be a slight restructure enabling a bunch of unit tests for the metrics collection class. Bug: 1177601 Change-Id: Ib8833796f8be0d7262a2b1ecb57c271a66a3ee27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2776031 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Reviewed-by: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#865305} commit fec2af5a3312062439bc8a97baabdf97fc2ad924 Author: Jan Wilken Dörrie <jdoerrie@chromium.org> Date: Thu Mar 11 16:52:52 2021 +0000 [LSC] Replace base::string16 with std::u16string in //c/b/ui/views This change replaces base::string16 with std::u16string in //chrome/browser/ui/views. Reproduction steps: $ git grep -lw 'base::string16' chrome/browser/ui/views | \ xargs sed -i 's/\bbase::string16\b/std::u16string/g' $ git cl format Bug: 1184339 Change-Id: Id3f21d3bf043dba8f651be34f4335310e2e6175c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2752226 Owners-Override: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#862005} commit e2124a1d261f70ffe0048553b0f4642e0444d6a1 Author: Caroline Rising <corising@chromium.org> Date: Fri Mar 5 19:30:23 2021 +0000 Clean up tab hover card feature flag and references. This feature has been launched on all platforms since M87. Bug: 910739 Change-Id: Idd71d4d25f084f24e9078bfe4853078b83d57967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2739381 Reviewed-by: Dana Fried <dfried@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#860314} commit dc5e8308d136551b4b96cd575997e9fcf8541a35 Author: Dana Fried <dfried@chromium.org> Date: Tue Mar 2 01:36:07 2021 +0000 Restore disabled test after code changes. The recording of tab hover cards seen should track specifically with events based on new code. If the test is still flaky we can roll this change back. Bug: 990210 Change-Id: I7aa275d7c40c52a8ec273471a39f625e84da4844 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2720386 Reviewed-by: Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#858821} commit 1f24ab638760a2d965b02c152442bb92edb7b8fa Author: Dana Fried <dfried@chromium.org> Date: Fri Feb 26 23:06:19 2021 +0000 Reland "Split Tab Hover Cards into view and controller." This reverts commit 7792ad296eb44bd00e8db891e85a363ab2966635. Reason for revert: Fix two potential issues: - null pointer dereference trying to close a hover card that is not open - incorrect show/flicker of hover card on page update in some cases (The later was causing the trybot failure; the former caused the attached bug.) Bug: 1182569 Original change's description: > Revert "Split Tab Hover Cards into view and controller." > > This reverts commit 3387f04559744177e8d0c19b0c66a6a14730de0d. > > Reason for revert: Consistent failure on linux-trusty-rel > Recent failure: https://ci.chromium.org/ui/p/chromium/builders/ci/linux-trusty-rel/21525/overview > > Original change's description: > > Split Tab Hover Cards into view and controller. > > > > Part of an effort to move hover cards to a MVC organization so that we > > can have more control over when cards are shown and what tabs they are > > shown for. Once the controller is separated, we can exert finer control > > over when the widget is created and destroyed and when thumbnails are > > requested. > > > > There are a number of outstanding performance issues that the above > > changes would facilitate, e.g. detecting quick move-across as per > > crbug.com/1177601 or just destroying the widget when we're not using it > > to save compositor memory. > > > > Note: This change should *not* affect any existing Hover Card behavior. > > If it does, that should be amended before improvements or optimizations > > are attempted. > > > > Change-Id: Icafe193337737b7736055bd3183b42f1ec140bcb > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2714213 > > Commit-Queue: Dana Fried <dfried@chromium.org> > > Reviewed-by: Caroline Rising <corising@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#857928} > > Change-Id: Id75208aa644688c2b377e25f60757c0e2e98e65f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2720025 > Auto-Submit: Jiewei Qian <qjw@chromium.org> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#857973} Change-Id: I8b2f86779916e00937375bbe4dc4233adc78c5a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2718539 Reviewed-by: Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#858326} commit 82700410f1c6a350e94858e0cf6d1f44e96dbad3 Author: Sean McAllister <smcallis@google.com> Date: Wed Aug 19 20:10:35 2020 +0000 Refactor OS_LINUX preprocessor directive for LaCrOS effort. Currently, ChromeOS defines the OS_LINUX directive as well as OS_CHROMEOS. We're working to separate these two, so we're making the fact that OS_LINUX == OS_LINUX || OS_CHROMEOS explicit. Bug: 1110266 Change-Id: Ibf45218c1ba6a609714ba80ee2d7bae28e929f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352689 Reviewed-by: Yuri Wiitala <miu@chromium.org> Reviewed-by: Michael Spang <spang@chromium.org> Reviewed-by: Jonathan Backer <backer@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Reviewed-by: Ken Rockot <rockot@google.com> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#799767} commit 6f281bcc104374e5ddd4f8268d7155a84a9fa078 Author: Jongmok Kim <jongmok.kim@navercorp.com> Date: Mon Aug 3 19:45:49 2020 +0000 [tabs] Inline DISALLOW_COPY_AND_ASSIGN in c/b/u/v/tabs Uses explicit deletion instead, removes use of base/macros.h. Bug: 1010217 Change-Id: I67e2e009d242537186e5feb0f2992fe44b35cecf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325526 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#794228} commit 919ce657e4e37dfa13758f1eb8fe0e9ef7ab1b20 Author: Peter Kasting <pkasting@chromium.org> Date: Thu May 7 10:22:36 2020 +0000 Add missing #includes of browser_test.h. This is a step towards doing full IWYU of browser_test.h, which will have other benefits. Completely mechanical and already R+ed as part of r765923. Tbr: sky Bug: none Change-Id: Icb7ab728098a6cf29c0920da4b524e96a7c024c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2186411 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#766361} commit 0ff4b9c05117390777ee54a1079085321919fb29 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Fri Apr 17 16:26:52 2020 +0000 [UI Cleanup] Use WidgetActivationWaiter in lieu of custom waiter Use WidgetActivationWaiter instead of a custom WindowDeactivatedWaiter in tabs/tab_hover_card_bubble_view_browsertest.cc. This is less code and reuses a common utility. Bonus: It fixes a small typo. :) Bug: None Change-Id: I09c2202ebe2b79dc7c0397d7cb59b2253e353377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151673 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Caroline Rising <corising@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#760086} commit 4d6086e6dc1c32eb35116a57ca2e7241181ce770 Author: Devlin Cronin <rdevlin.cronin@chromium.org> Date: Thu Apr 16 18:12:40 2020 +0000 [UI Cleanup] Introduce common WidgetVisibleWaiter Introduce a common views::test::WidgetVisibleWaiter helper class to enable tests to easily wait for a given widget to become visible, and use it in place of places that had similar functionality. Bug: None Change-Id: I4fda7baeef12ae33f47a47393a58396f917b65e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151343 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759725} commit 3074c550a2fabdef0036540699226a0babcea2b8 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Feb 18 09:59:04 2020 +0000 Re-enable extensions toolbar menu and tab hover card browser tests. After landing crrev.com/c/2054095 these tests should no longer be flaky, so they are re-enabled. If one of these tests begins flaking independent of the others, please disable it individually. Bug: 1050712, 1049036, 1049063, 1048980, 1048956, 932402, 947668 Change-Id: I2a18bdad8ae07155a0ff9333e7547e0338d07834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059413 Reviewed-by: Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#742095} commit 49bf6e021eb90a3486d2b1ccac933a071b755b8a Author: Bret Sepulveda <bsep@chromium.org> Date: Mon Feb 17 15:17:39 2020 +0000 Prevent mouse events from triggering hover cards in browser tests. If the mouse happens to be in exactly the wrong position it triggers a hover card, which can cause strange failures in some tests, especially on bots where the mouse can cause the test to fail repeatedly until it happens to be moved. To fix this, this patch prevents Tab::OnMouseEntered from triggering hover cards when running an InProcessBrowserTest. Also changes hover card browser tests to call TabStrip::UpdateHoverCard instead of Tab::OnMouseEntered to get around that method now being disabled, and does some light refactoring. Bug: 1050012 Change-Id: I96523b13659a5ed0cbcedc66d7cdb64c7483df72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054095 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#741922} commit 3074c550a2fabdef0036540699226a0babcea2b8 Author: Bret Sepulveda <bsep@chromium.org> Date: Tue Feb 18 09:59:04 2020 +0000 Re-enable extensions toolbar menu and tab hover card browser tests. After landing crrev.com/c/2054095 these tests should no longer be flaky, so they are re-enabled. If one of these tests begins flaking independent of the others, please disable it individually. Bug: 1050712, 1049036, 1049063, 1048980, 1048956, 932402, 947668 Change-Id: I2a18bdad8ae07155a0ff9333e7547e0338d07834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059413 Reviewed-by: Huanzhong Huang <huanzhong@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#742095}

Double-quoted string literals are non-standard SQL. Allowing double-quoted string literals is now considered a misfeature by SQLite authors. See https://www.sqlite.org/quirks.html#dblquote This CL converts existing occurrences of double-quoted string literals in Brave code, to fix many unit and browser tests in cr94: Unit tests fixed (10): * LedgerDatabaseMigrationTest.SchemaCheck * LedgerDatabaseMigrationTest.Migration_11_ContributionInfo * LedgerDatabaseMigrationTest.Migration_12_ContributionInfo * LedgerDatabaseMigrationTest.Migration_13_Promotion * LedgerDatabaseMigrationTest.Migration_14_UnblindedToken * LedgerDatabaseMigrationTest.Migration_16_ContributionInfo * LedgerDatabaseMigrationTest.Migration_4_ActivityInfo * LedgerDatabaseMigrationTest.Migration_5_ActivityInfo * LedgerDatabaseMigrationTest.Migration_6_ActivityInfo * LedgerDatabaseMigrationTest.Migration_8_PendingContribution Browser tests fixed (32): * RewardsBrowserTest.ShowACPercentInThePanel * RewardsBrowserTest.ShowMonthlyIfACOff * RewardsBrowserTest.SiteBannerDefaultPublisherAmounts * RewardsBrowserTest.SiteBannerDefaultTipChoices * RewardsContributionBrowserTest.AutoContributeWhenACOff * RewardsContributionBrowserTest.AutoContribution * RewardsContributionBrowserTest.AutoContributionMultiplePublishers * RewardsContributionBrowserTest.AutoContributionMultiplePublishersUphold * RewardsContributionBrowserTest.CheckIfReconcileWasReset * RewardsContributionBrowserTest.CheckIfReconcileWasResetACOff * RewardsContributionBrowserTest.MultipleRecurringOverBudgetAndPartialAutoContribution * RewardsContributionBrowserTest.PanelMonthlyTipActions * RewardsContributionBrowserTest.PanelMonthlyTipAmount * RewardsContributionBrowserTest.PendingContributionTip * RewardsContributionBrowserTest.ProcessPendingContributions * RewardsContributionBrowserTest.RecurringAndPartialAutoContribution * RewardsContributionBrowserTest.RecurringTipNonIntegralAmount * RewardsContributionBrowserTest.SplitProcessOneTimeTip * RewardsContributionBrowserTest.SplitProcessorAutoContribution * RewardsContributionBrowserTest.TipConnectedPublisherAnon * RewardsContributionBrowserTest.TipConnectedPublisherAnonAndConnected * RewardsContributionBrowserTest.TipNonIntegralAmount * RewardsContributionBrowserTest.TipVerifiedPublisher * RewardsContributionBrowserTest.TipVerifiedPublisherWithCustomAmount * RewardsContributionBrowserTest.TipWithVerifiedWallet * RewardsNotificationBrowserTest.InsufficientNotificationForACNotEnoughFunds * RewardsNotificationBrowserTest.InsufficientNotificationForInsufficientAmount * RewardsNotificationBrowserTest.InsufficientNotificationForVerifiedInsufficientAmount * RewardsPublisherBrowserTest.VisitRegisteredPublisher * RewardsPublisherBrowserTest.VisitUnverifiedPublisher * RewardsPublisherBrowserTest.VisitVerifiedPublisher * RewardsStateBrowserTest.State_2 Chromium change: https://source.chromium.org/chromium/chromium/src/+/4e442d06cae3d524854ff444a2bbe869c9d7f6bc commit 4e442d06cae3d524854ff444a2bbe869c9d7f6bc Author: Victor Costan <pwnall@chromium.org> Date: Tue Jul 20 17:43:13 2021 +0000 sql: Disable double-quoted string literals for sql::Database users. Double-quoted string literals are non-standard SQL. Allowing double-quoted string literals is now considered a misfeature by SQLite authors. See https://www.sqlite.org/quirks.html#dblquote Disabling double-quoted string literals for sql::Database users is the best we can do for now, because WebSQL still needs SQLite support for this misfeature. After we remove WebSQL, we can remove double-quoted string literal support from SQLite. Bug: 1230199

Chromium change: https://chromium.googlesource.com/chromium/src/+/98851198b9ec02d29ffb148f3a0642a9b69f931a [AADC] Update link to privacy policy in settings page This cl updates "Chrome Privacy Notice" to "Google Privacy Policy" and changes the link to point to https://policies.google.com/privacy for everyone. Screenshot: https://crbug.com/1220661#c6 Bug: 1220661

…4589.2.

//c/b/notifications have been migrated to C++ and now reuse notifications code in //c/services/mac_notifications. Chromium changes: https://chromium.googlesource.com/chromium/src/+/83c4fd04ac6f669d41c97b2c4088e63daaad87af commit 83c4fd04ac6f669d41c97b2c4088e63daaad87af Author: Richard Knoll <knollr@chromium.org> Date: Fri Jul 23 10:12:19 2021 +0000 Rename notification files from .mm to .cc These files are no longer written in Obj-C so renaming them to standard C++ conventions. Also makes sure to match filenames with the class names after recent cleanup CLs. Mechanical renaming CL only, no functional changes. Bug: 1170731 https://chromium.googlesource.com/chromium/src.git/+/ab5db760df1eb0fc8944007757a266095c42a1e6 commit ab5db760df1eb0fc8944007757a266095c42a1e6 Author: Richard Knoll <knollr@chromium.org> Date: Thu Jul 22 11:04:59 2021 +0000 Reuse macOS notification service in-process This removes the duplicated macOS notification API implementation from //c/b/notifications and reuses the one we already have for alerts in //c/services/mac_notifications. This drastically reduces complexity and gets rid of all the remaining code in //c/b/ui/cocoa/notifications. All the code in //c/b/notifications is now C++ only and will be renamed in a follow-up CL from *.mm to *.cc. Bug: 1170731

Only need to depend on //base now, and include the right header file. Chromium change: https://chromium.googlesource.com/chromium/src/+/276d6ff9d4944379459152d65d303e912a2d514e commit 276d6ff9d4944379459152d65d303e912a2d514e Author: Albert J. Wong <ajwong@chromium.org> Date: Mon Jul 26 17:47:49 2021 +0000 Merge //base/util/timer back in to //base/timer. This is part of merging all of //base/util back into //base. Bug: 1227210

Only need to depend on //base now, and include the right header file. Chromium change: https://chromium.googlesource.com/chromium/src/+/f60c8d2b2478e42fe420cb5012e304d72f1f2613 commit f60c8d2b2478e42fe420cb5012e304d72f1f2613 Author: Albert J. Wong <ajwong@chromium.org> Date: Tue Jul 27 07:25:26 2021 +0000 Merge //base/util/values into //base/json This is part of merging all of //base/util back into //base. Bug: 1227210

SyncServiceImpl::StopAndClearImpl() does no longer exist. Chromium change: https://chromium.googlesource.com/chromium/src/+/7cb789be3f4235cdcb81dd09c8e495c97453a856 commit 7cb789be3f4235cdcb81dd09c8e495c97453a856 Author: Marc Treib <treib@chromium.org> Date: Thu Jul 22 17:28:33 2021 +0000 Merge SyncServiceImpl::StopAndClearImpl into ::StopAndClear They were effectively identical. In the past, there used to be two differences between them: - StopAndClearImpl used to *not* automatically restart the engine, but this difference was removed in crrev.com/c/3021086. - StopAndClearImpl used to *not* set SyncRequested to false, but that difference was removed in crrev.com/c/2532554. This CL also slightly changes the timing of when exactly SyncRequested gets set to false during StopAndClear(). As of crrev.com/c/3034843 (making TryStart() guaranteed-async), such timing details are much less critical. Bug: 1229171

The old function was wrong and has been deprecated. Chromium change: https://chromium.googlesource.com/chromium/src/+/d29a091932c8edc826e6d3909fd332ee70944b69 commit d29a091932c8edc826e6d3909fd332ee70944b69 Author: Avi Drissman <avi@chromium.org> Date: Tue Jul 27 18:47:22 2021 +0000 Rename base::ClampToRange and annotate all remaining users base::ClampToRange should not be used, so rename it appropriately. Annotate all of its remaining users with the bugs that are already assigned to them. Bug: 1231569 Bug: 1231833 Bug: 1231837 Bug: 1231839 Bug: 1231842 Bug: 1232262 Bug: 1232264 Bug: 1232414 Bug: 1232445

Chromium change: https://chromium.googlesource.com/chromium/src/+/bc51d5e6bf8a72ab8208cfb7e80f3c1941fddc40 commit bc51d5e6bf8a72ab8208cfb7e80f3c1941fddc40 Author: Mitsuru Oshima <oshima@chromium.org> Date: Mon Jul 26 23:19:22 2021 +0000 Rename ScaleFactor to ResourceScaleFactor (last patch) * ui::ScaleFactor -> ui::ResourceScaleFactor in chrome/browser * Rename ResourceBundle::GetMaxScaleFactor -> ResourceBundle::GetMaxResourceScaleFactor * Remove old enum and functions Bug: 1217405

BrowserList::{begin,end}_last_active() do not longer exist upstream. Chromium change: https://chromium.googlesource.com/chromium/src/+/09a5178a07c37e67ded05db80fe2455001fa57ca commit 09a5178a07c37e67ded05db80fe2455001fa57ca Author: chinsenj <chinsenj@chromium.org> Date: Thu Jul 22 20:16:22 2021 +0000 chrome: All browsers are added to the `BrowserList`'s active browsers. Currently when browsers are restored using Full Restore they don't appear in the "Move Tab to Another Window" menu. This is because their activation is blocked during restoration, preventing them from being added to the `BrowserList`'s list of active browsers. This list is used to generate the "Move Tab to Another Window" menu so this causes the restored browsers to be omitted. More generally, in the code there is an assumption that BrowserList::last_active_browsers_ contains all the browsers, with the caveat that they're sorted by activation order. To make the name reflect this, this CL renames BrowserList::last_active_browsers_ to BrowserList::browsers_ordered_by_activation_ and changes its related functions accordingly. This CL partially fixes the aforementioned bug since Full Restore'd browsers will be added to the "Move Tab to Another Window" menu, but they won't be in the correct order. A subsequent CL will address this and fully fix the bug. Bug: 1228380

They should be translate::prefs::kOfferTranslateEnabled now. Chromium change: https://chromium.googlesource.com/chromium/src/+/bc25ee0ba9a39f8d3071a8b50717680ac2e4fffe commit bc25ee0ba9a39f8d3071a8b50717680ac2e4fffe Author: Trevor Perrier <perrier@chromium.org> Date: Thu Jul 22 17:08:13 2021 +0000 [Translate] Move translate_pref_names to translate namespace This CL moves the values in translate_pref_names from the prefs namespace to the translate::prefs namespace. This aligns the namespaces with the convention from other packages. This CL also updates all of the tests in c.b.translate to be in the translate namespace and use an internal anonymous namespace. Bug: 1197367

//chrome/browser/net/system_network_context_manager.cc is wrongly using network::ResourceRequest without including it first, which is causing a build failure on Brave due to overrides, so let's make sure that such header is included before using that type.

The GetVariationsList() now returns a base::Value instead of an unique pointer to it, so we need to adapt our override not to run into a crash each time brave://version is loaded. Chromium change: https://chromium.googlesource.com/chromium/src/+/041d61b7525b6878ac70e6e112adbbe926c7b371 commit 041d61b7525b6878ac70e6e112adbbe926c7b371 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Jul 26 18:03:16 2021 +0000 [CodeHealth] Modernize base::Value code in //components/version_ui Avoid DictionaryValue and ListValue, as they are deprecated. Get rid of some temporary heap allocation. Bug: 1187062

These tests are failing due to a new CHECK() beind added upstream in views::View:GetNativeTheme() to prevent the global NativeTheme from being used, which requires some adaptation in our code similar to what upstream has done already (see bug 1056756 [1]) in order to avoid that when building instances of BraveTranslateBubbleView. To fix this, let's use RegisterWidgetInitializedCallback() on the BraveTranslateBubbleView::BraveCreateViewBeforeTranslate() method, which is already being called after the associated widget is created but before it is shown (i.e. via BraveTranslateBubbleView::Init()), to delay relying on the GetNativeTheme() until we know for sure that the associated widget has been initialized. This fixes the following 4 unit tests: * BraveTranslateBubbleViewTest.BraveBeforeTranslateView * BraveTranslateBubbleViewTest.CancelButton * BraveTranslateBubbleViewTest.ReturnKey * BraveTranslateBubbleViewTest.TranslateButton [1] http://crbug.com/1056756 Chromium change: https://chromium.googlesource.com/chromium/src/+/550395f9e46509fa8c1d165f73be579614cd738f commit 550395f9e46509fa8c1d165f73be579614cd738f Author: tom <tluk@chromium.org> Date: Mon Jul 26 17:42:20 2021 +0000 Reland "[views] Add CHECK to prevent fallthrough to global NativeTheme" This is a reland of 93850eca7ee7369c0600f9558649d521b8f6d2eb The original CL caused CHECK crashes in MenuItemViews (fixed crrev.com/c/3043661) and LocalCardMigrationDialogView (fixed crrev.com/c/3043146). Original change's description: > [views] Add CHECK to prevent fallthrough to global NativeTheme > > This CL adds a CHECK to View::GetNativeTheme() to catch any > remaining fallthrough to the global NativeTheme instance. > > Bug: 1056756 > Change-Id: I690ab0cfddc99495e9635f411feb17208f9e34d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3029188 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#903079} Bug: 1056756

Fixes error: Apps targeting Android 12 and higher are required to specify an explicit value for `android:exported` when the corresponding component has an intent filter defined. See https://developer.android.com/guide/topics/manifest/activity-element#exported for details.

Chromium change: https://chromium.googlesource.com/chromium/src/+/711bdf1ad585298e50956108a8602baef7d8400e [Dino Widget] Created a stub for the Dino Widget. In this CL, we add a stub implementation for the Dino widget as a variant of the Quick Action Search Widget

The following test is currently failing due to a new CHECK added upstream, that makes sure GetNativeTheme() does NOT fall through to the global NativeTheme: * AdNotificationPopupBrowserTest.CheckThemeChanged We need to make sure the calls that get the native theme don't happen to early, but whenever there are theme-related changes. Chromium change: https://chromium.googlesource.com/chromium/src/+/550395f9e46509fa8c1d165f73be579614cd738f commit 550395f9e46509fa8c1d165f73be579614cd738f Author: tom <tluk@chromium.org> Date: Mon Jul 26 17:42:20 2021 +0000 Reland "[views] Add CHECK to prevent fallthrough to global NativeTheme" This is a reland of 93850eca7ee7369c0600f9558649d521b8f6d2eb The original CL caused CHECK crashes in MenuItemViews (fixed crrev.com/c/3043661) and LocalCardMigrationDialogView (fixed crrev.com/c/3043146). Original change's description: > [views] Add CHECK to prevent fallthrough to global NativeTheme > > This CL adds a CHECK to View::GetNativeTheme() to catch any > remaining fallthrough to the global NativeTheme instance. > > Bug: 1056756 > Change-Id: I690ab0cfddc99495e9635f411feb17208f9e34d7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3029188 > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#903079} Bug: 1056756

…4590.5.

There's an additional TabMenuModelDelegate* parameter now. Chromium change: https://chromium.googlesource.com/chromium/src/+/009cef97beecf18816e4de8605af75fa56ef7f9c commit 009cef97beecf18816e4de8605af75fa56ef7f9c Author: chinsenj <chinsenj@chromium.org> Date: Wed Jul 28 01:14:53 2021 +0000 TabMenu: Move usage of Browser to TabMenuModelDelegate. Currently the ExistingWindowSubMenuModel relies on the TabMenuModel to retrieve the list of existing windows names. In the future, this will need to retrieve the actual Browser classes for the existing windows. However, TabMenuModel shouldn't depend directly on Browser. This CL moves GetExistingWindowsForMoveMenu() into the new TabMenuModelDelegate interface which can depend on Browser. Bug: 1221287

Chromium change: https://source.chromium.org/chromium/chromium/src/+/ab18615521c989bab965f07935b6ee0db609b566 commit ab18615521c989bab965f07935b6ee0db609b566 Author: Greg Thompson <grt@chromium.org> Date: Fri Jul 23 21:28:39 2021 +0000 Make channel selection via setup.exe --channel on Windows sticky. Among other things: Use a channel override as the only source of truth for channel determination for the primary install mode on Windows (i.e., stable channel installs). Neither the installer nor the browser now bases its channel on the "ap" value. Channel determination is now done in setup.exe by --channel=foo (which is provided by the update server for all updates driven by Google Update) and in chrome.exe by the "channel" value in Chrome's Clients key (which is provided to the browser by setup.exe). Since "ap" (additional parameters) is no longer the source, ChannelStrategy::ADDITIONAL_PARAMETERS is now known as FLOATING. Bug: 1229222

We should use blink::features::kLangClientHintHeader now. Also, we need to adapt the chromium_src override to disable all the client hints as we need to patch enabled_client_hints.cc now, instead of web_client_hints_type.h, no longer present upstream. Chromium change: https://chromium.googlesource.com/chromium/src/+/a6b0fb6ff3762fe6d9458f781c489123feaa8d75 commit a6b0fb6ff3762fe6d9458f781c489123feaa8d75 Author: Ali Beyad <abeyad@chromium.org> Date: Wed Jul 28 00:13:24 2021 +0000 Check Accept-CH filters before adding a client hint to the request It was discovered that, when applying Critical-CH client hints, the critical client hints would only be filtered if they did not appear in the Accept-CH response header. However, we apply some filters to the Accept-CH response header before persisting the client hints in the Accept-CH cache. The filters currently are just features guarded by a feature flag, but in the future, we will also want Accept-CH values to be gated by the presence of an Origin Trial (see crbug.com/1226193 for an example). In crrev.com/c/2983659, the same Accept-CH filter was applied on Critical-CH as is applied when persisting client hints in the Accept-CH cache. This was intended as a temporary solution to fix the bug. However, it does not solve for the fact that the filtering logic on Accept-CH values happen in two places (when parsing and persisting the Accept-CH header and when processing the Critical-CH values). This CL unifies the logic of filtering Accept-CH values in one place. Instead of filtering Accept-CH values when persisting the hints in the Accept-CH cache, we persist the Accept-CH hints as given to us in the response header. Only when adding the client hints to the request header do we check for any Accept-CH values that must be filtered before adding to the request header. We use the same logic to also determine if the value(s) in the Critical-CH header should cause a resend of the request with the critical client hints in the request header. Bug: 1231630

Chromium change: https://chromium.googlesource.com/chromium/src/+/bd2d4b7116ef955394188f334ddaaee26cb328c6 [Autofill/Passwords] Clean-up old Autofill bubble header images Bug: 1213685

…4595.3

Relocation: tools/metrics/histograms/{histograms_xml => metadata} Chromium change: https://source.chromium.org/chromium/chromium/src/+/97734583a65508dc90b68bec287d517de61d8f45 commit 97734583a65508dc90b68bec287d517de61d8f45 Author: Peter Kasting <pkasting@chromium.org> Date: Thu Jul 29 14:05:59 2021 +0000 Rename "histograms_xml" dir to "metadata". This change looks enormous but consists of only a few steps: * Open all files containing the string "histograms_xml", do a global case-sensitive search-and-replace this with "metadata", then revert the changes in tools/metrics/BUILD.gn * cd tools/metrics/histograms && git mv histograms_xml metadata Bug: 1133549

A new preconnect_to_search_url parameter has been added. Chromium change: https://source.chromium.org/chromium/chromium/src/+/453b22336b4546cf64373bfc8a7ba9ed31c24fff commit 453b22336b4546cf64373bfc8a7ba9ed31c24fff Author: Ryan Sturm <ryansturm@chromium.org> Date: Wed Jul 28 23:52:53 2021 +0000 Adding a prepoluated search preconnect field This CL adds a way for other searh engines to opt into the DSE preconnect feature.

We need to use Value::FindStringKey() now. Chromium change: https://source.chromium.org/chromium/chromium/src/+/96031441f2a47c3d4af05b7271d30a46cf61b6c5 commit 96031441f2a47c3d4af05b7271d30a46cf61b6c5 Author: Song Fangzhen <songfangzhen@bytedance.com> Date: Fri Jul 30 09:26:58 2021 +0000 CodeHealth: Remove DictionaryValue::GetStringWithoutPathExpansion After removing the use of DictionaryValue::GetStringWithoutPathExpansion, now DictionaryValue::GetStringWithoutPathExpansion itself should be removed. Bug: 1187046

Methods from the storage.mojom.LocalStorageControl mojo interface have migrated from url.mojom.Origin to blink.mojom.StorageKey, so we need to adapt our implementation of storage::LocalStorageImpl to account for that change. Chromium change: https://source.chromium.org/chromium/chromium/src/+/fecbcc550638152eddbb67adf1ea3530e741a39f commit fecbcc550638152eddbb67adf1ea3530e741a39f Author: Ari Chivukula <arichiv@chromium.org> Date: Thu Jul 29 20:34:07 2021 +0000 Migrate LocalStorageControl to StorageKey This is part of a larger effort to migrate dom_storage to use storage_key in preparation for storage partitioning. Bug: 1212808

Added param for Android as well. A new preconnect_to_search_url parameter has been added. Chromium change: https://source.chromium.org/chromium/chromium/src/+/453b22336b4546cf64373bfc8a7ba9ed31c24fff commit 453b22336b4546cf64373bfc8a7ba9ed31c24fff Author: Ryan Sturm <ryansturm@chromium.org> Date: Wed Jul 28 23:52:53 2021 +0000 Adding a prepoluated search preconnect field This CL adds a way for other searh engines to opt into the DSE preconnect feature.

Chromium change: https://chromium.googlesource.com/chromium/src/+/85f26080b73cbebba54e116cde7b5f504088732b [Start] Stop using triggerUrlFocusAnimation() for expanding toolbar phone when url bar is not focused. 1. Adds |mStartSurfaceScrollFraction| for expanding toolbar phone and stops using triggerUrlFocusAnimation(). 2. Updates the bounds of the location bar based on Start surface status. Bug: 1234103

Otherwise npm run lint will fail anytime each of these files change.

…4603.0

…ration Chromium change: https://source.chromium.org/chromium/chromium/src/+/fd281816371019aaeee0ecb56f5e15365b12efd3 commit fd281816371019aaeee0ecb56f5e15365b12efd3 Author: dpapad <dpapad@chromium.org> Date: Tue Aug 3 11:28:27 2021 +0000 Settings TypeScript: Migrate a few files shared between OS and Browser. Bug: 1234307

Chromium change: https://source.chromium.org/chromium/chromium/src/+/a17b47dfee8b1422408466438fa15482586f2b43 commit a17b47dfee8b1422408466438fa15482586f2b43 Author: dpapad <dpapad@chromium.org> Date: Tue Aug 3 10:03:40 2021 +0000 [Reland] Settings TypeScript: Migrate a few simple files. General approach for shared files: 1) Migrate a file to TS. 2) Update js_library() target (if it exists) to point to the generated JS file in TS compiler's output folder. The above allows preserving some Closure type checks while the migration is in progress (mostly relevant for CrOS Settings). The approach above only works for simple files that don't export any types. Other shared files will need to be forked, as it is not possible to satisfy Closure compiler by simply consuming TS Compiler's JS output. Bug: 1234307

Chromium change: https://source.chromium.org/chromium/chromium/src/+/49b199dfb0d8f48134c57bf4b07c1c78ee67d805 commit 49b199dfb0d8f48134c57bf4b07c1c78ee67d805 Author: Victor Hugo Vianna Silva <victorvianna@google.com> Date: Wed Aug 4 14:05:21 2021 +0000 [base][CodeHealth] Remove deprecated Value::GetAsDouble() Remove the remaining uses and delete the deprecated API. Fixed: 1187006

metrics::LogStore::~LogStore() is now declared a virtual method. Chromium change: https://source.chromium.org/chromium/chromium/src/+/f5d229fef2651c48365f04fe18f40660c8a2c560 commit f5d229fef2651c48365f04fe18f40660c8a2c560 Author: Jonghyun Ahn <jongahn@google.com> Date: Wed Aug 4 00:42:21 2021 +0000 Add user log store logic to metrics_log_store and expose the API at metrics_service. The idea is to create a Chrome OS specific service in a follow-up CL owned by the ChromeMetricsServiceClient that will control user related events (ie on login, load user logs, consent, user_id, etc). Changes needed to be made in metrics_log_store since it is used by the reporting_service to send logs to stage logs from the user_log_store if bound. If no user log store is bound, this should be a no-op from the existing implementation. Bug: 1181504

Create a blink::StorageKey out of the url::Origin as returned by TakeEphemeralStorageOpaqueOrigins() in order to pass it to DOMStorageContextWrapper::DeleteLocalStorage(), which no longer expects a url::Origin. TODO: Check with Alexey whether it would make sense to make changes to have TakeEphemeralStorageOpaqueOrigins() return storage keys instead (and rename the method accordingly). Chromium change: https://source.chromium.org/chromium/chromium/src/+/fecbcc550638152eddbb67adf1ea3530e741a39f commit fecbcc550638152eddbb67adf1ea3530e741a39f Author: Ari Chivukula <arichiv@chromium.org> Date: Thu Jul 29 20:34:07 2021 +0000 Migrate LocalStorageControl to StorageKey This is part of a larger effort to migrate dom_storage to use storage_key in preparation for storage partitioning. Bug: 1212808

…mojom.h

We were passing always true anyway, which is now the implemented behaviour for View::RemoveAllChildViews(). Chromium change: https://source.chromium.org/chromium/chromium/src/+/67ae1a9a3cf6946f7c18f852ff975e5e2b1e21bc commit 67ae1a9a3cf6946f7c18f852ff975e5e2b1e21bc Author: Peter Boström <pbos@chromium.org> Date: Thu Aug 5 21:27:35 2021 +0000 Reland "Remove `delete_children` RemoveAllChildViews() arg" This reverts commit 4eaec1f7aad4f961386c6583a5dc87b7c955cbda. Reason for revert: Relanding with conflict addressed. This collided with crrev.com/c/3069244 which was simultaneously landed. Original change's description: > Revert "Remove `delete_children` RemoveAllChildViews() arg" > > This reverts commit d6240fed8c4d31c9920a32df6f10b469b29ce643. > > Reason for revert: compile failure https://cr-buildbucket.appspot.com/build/8839712642281727265 > > Original change's description: > > Remove `delete_children` RemoveAllChildViews() arg > > > > This removes the last few call sites with non-default arguments. > > TriView::RemoveAllChildren() was the only remaining one with a > > non-constant argument but it turns out to be dead code. > > > > Bug: 1044687 > > Change-Id: Ifc233b1613a9b49384c82cdbd7810914b8f8cc07 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3074817 > > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > > Commit-Queue: Peter Boström <pbos@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#908973} > > Bug: 1044687 > Change-Id: Ic23291890eef38d00402ce09b0849171063e8c02 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3075263 > Auto-Submit: Joshua Pawlicki <waffles@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Owners-Override: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#908980} Bug: 1044687

This only affects tests, so we can provide absl::nullopt. Chromium change: https://source.chromium.org/chromium/chromium/src/+/f4a802bc0723af9facf34ad82c192bbd92257074 commit f4a802bc0723af9facf34ad82c192bbd92257074 Author: Dylan Cutler <dylancutler@google.com> Date: Tue Aug 3 16:38:54 2021 +0000 Add cookie_partition_key argument to CanonicalCookie::Create. Bug: 1225444

The |site_for_cookies| parameter is now a net::SiteForCookies, instead of a GURL. Chromium change: https://source.chromium.org/chromium/chromium/src/+/b7a6e74b0f7070dbc595b84bfbbf40b71f2f1db8 commit b7a6e74b0f7070dbc595b84bfbbf40b71f2f1db8 Author: Ari Chivukula <arichiv@chromium.org> Date: Fri Aug 6 20:43:41 2021 +0000 [GURL -> SiteForCookies] components/content_settings/common/content_settings_manager.mojom This is part of a larger effort to replace GURL with SiteForCookies to simplify/consolidate comparison and increase safety. This file was found by looking for mojom files as follows: https://source.chromium.org/search?q=%22mojom.Url%20site_for_cookies%22 Bug: 577565

@domenic

MimeClassInfo now requires to pass a list of extensions to the constructor, so we need to generate at least a random one to create the fake MimeClassInfo used for farbling purposes. Note that 3 browser tests failing likely because of this patch: BraveNavigatorPluginsFarblingBrowserTest.FarbleNavigatorPlugins BraveNavigatorPluginsFarblingBrowserTest.FarbleNavigatorPluginsBuiltin BraveNavigatorPluginsFarblingBrowserTest.FarbleNavigatorPluginsReset This is because of Chromium now enabling a feature that will return a hardcoded list via navigator.plugins which is incompatible with Brave's farbling code. That will be addressed in the next patch. Chromium change: https://source.chromium.org/chromium/chromium/src/+/fb96360c18b517bcc487c0de7235eec27e3adf5e commit fb96360c18b517bcc487c0de7235eec27e3adf5e Author: Mason Freed <masonf@chromium.org> Date: Fri Aug 6 20:20:17 2021 +0000 Hard-code the list of plugins and mimetypes in navigator See [1] for a previous attempt to completely empty the navigator.plugins and navigator.mimeTypes APIs. That caused site breakage due to sites scanning for a PDF reader. This new attempt is discussed in significant detail in [2], and involves the hard-coding of a list of PDF viewers and mime types. The plugins/mimetypes lists will be empty if the user setting to download PDFs instead of viewing them (chrome://settings/content/pdfDocuments) is enabled. This is to ensure compat with sites that scan the plugins list for specific PDF plugins to decide on behavior. Prior to this CL, when the PDF viewer is disabled, the PDF viewer plugins are unloaded. Tests were copied mostly verbatim from [3], thanks @domenic. I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/bbxAGu90LgM [1] https://chromium-review.googlesource.com/c/chromium/src/+/2783393 [2] whatwg/html#6738 [3] web-platform-tests/wpt#29559 Bug: 1164635

@domenic

The CL below made a change to make fingerprinting more difficult in Chromium without breaking existing sites by returning a fixed list of PDF plugins, regardless of the actual ones available, which broke our farbling of the navigator.plugins array. Since farbling in Brave works in a different way (i.e. differently depending on the selected "farbling level"), we're just disabling this runtime feature to get back to the original code we had before, which would make sure the actual list of plugins is only returned if the used has explicitly disabled fingerprinting protections, otherwise a farbled, randomly generated and always different list of plugins will be returned (which is better than a fixed list anyway). Chromium change: https://chromium.googlesource.com/chromium/src/+/fb96360c18b517bcc487c0de7235eec27e3adf5e commit fb96360c18b517bcc487c0de7235eec27e3adf5e Author: Mason Freed <masonf@chromium.org> Date: Fri Aug 6 20:20:17 2021 +0000 Hard-code the list of plugins and mimetypes in navigator See [1] for a previous attempt to completely empty the navigator.plugins and navigator.mimeTypes APIs. That caused site breakage due to sites scanning for a PDF reader. This new attempt is discussed in significant detail in [2], and involves the hard-coding of a list of PDF viewers and mime types. The plugins/mimetypes lists will be empty if the user setting to download PDFs instead of viewing them (chrome://settings/content/pdfDocuments) is enabled. This is to ensure compat with sites that scan the plugins list for specific PDF plugins to decide on behavior. Prior to this CL, when the PDF viewer is disabled, the PDF viewer plugins are unloaded. Tests were copied mostly verbatim from [3], thanks @domenic. I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/bbxAGu90LgM [1] https://chromium-review.googlesource.com/c/chromium/src/+/2783393 [2] whatwg/html#6738 [3] web-platform-tests/wpt#29559 Bug: 1164635

Chromium change: https://chromium.googlesource.com/chromium/src/+/be2eae1c83be911e7154acef8a86660482918cdf [Shortcuts Widget] Implemented the UI of the small version of the widget This CL introduces a second version of the Quick Action Search Widget that is one row tall and doesn't include dino. With this change, two versions of the Quick Action Search Widget will appear in the widget picker (medium and small). Note that this CL doesn't include dynamically resizing the widget to switch between medium and small layouts, that will come in a later CL. Screenshot: http://screen/C6NuGTaFfZXkcER.png Bug: 1213541

Chromium change: https://chromium.googlesource.com/chromium/src/+/020d9a658e7ae62272fcbcf66868c51c13b9779b Update omnibox with dynamic colors This CL updates methods that provide the primary color or the background in utility classes such as ChromeColors and ThemeUtils to use Context instead of Resources. Bug: 1217157

Removed unit test that no longer applies. Upstream added similar unit test for command line channel override, but we are not using such override, so I am not adding those tests to our repo. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/ab18615521c989bab965f07935b6ee0db609b566 commit ab18615521c989bab965f07935b6ee0db609b566 Author: Greg Thompson <grt@chromium.org> Date: Fri Jul 23 21:28:39 2021 +0000 Make channel selection via setup.exe --channel on Windows sticky. Among other things: Use a channel override as the only source of truth for channel determination for the primary install mode on Windows (i.e., stable channel installs). Neither the installer nor the browser now bases its channel on the "ap" value. Channel determination is now done in setup.exe by --channel=foo (which is provided by the update server for all updates driven by Google Update) and in chrome.exe by the "channel" value in Chrome's Clients key (which is provided to the browser by setup.exe). Since "ap" (additional parameters) is no longer the source, ChannelStrategy::ADDITIONAL_PARAMETERS is now known as FLOATING. Bug: 1229222

Chromium change: https://chromium.googlesource.com/chromium/src/+/9bb17bfbf232dcc3365a3b781ef62ae18e747d23 Add Android setting for HTTPS-First Mode This adds a new setting to the "Privacy and Security" settings subpage for HTTPS-First Mode, and hooks it up to the native pref and enterprise policy. Note that new code added in this CL refers to this as "HTTPS-First Mode" but still references or calls into old code that still refers to this as "HTTPS-Only Mode". A followup CL will handle more of the renaming. Bug: 1218526

…4606.12.

Chromium change: https://chromium.googlesource.com/chromium/src/+/58d87d028a924673703aa8b635669099b045d9aa commit 58d87d028a924673703aa8b635669099b045d9aa Author: Yi Xu <yiyix@chromium.org> Date: Thu Aug 12 17:03:13 2021 +0000 [OffscreenCanvas] Add EnforceRange to createImageData and putImageData The spec change is done here: whatwg/html#6263 and canvasRenderingContext2D has updated. Update the OffscreenCanvas to reflect the spec change. Bug: 1068691

Chromium change: https://source.chromium.org/chromium/chromium/src/+/e11cb619b88c31e70cdcd5c92e1f459e1da4ccf9 commit e11cb619b88c31e70cdcd5c92e1f459e1da4ccf9 Author: Zhuoyu Qian <zhuoyu.qian@samsung.com> Date: Wed Aug 11 06:46:37 2021 +0000 Use a reference of CookieSettings instead of a pointer. The variable of cookie_settings_ of RestrictedCookieManager never be nullptr, change it to be a reference.

It was removed from the .cc file being overriden upstream, but we still find it useful for our override, so let's bring it back. Chromium change: https://source.chromium.org/chromium/chromium/src/+/dea55e7ac9aa4b172d34132a92a0ca3182713b15 commit dea55e7ac9aa4b172d34132a92a0ca3182713b15 Author: Peter Boström <pbos@chromium.org> Date: Tue Aug 10 21:04:09 2021 +0000 Add views::GetCascadingAccentColor() This externalizes FocusRing's accent color so that it can be used outside the FocusRing. It's applied to the Omnibox focus indicator as a start, but other uses may come to include prominent buttons and the bookmark star. To support GetCascadingAccentColor(), GetCascadingBackgroundColor() is added as well. Bug: 1215564

Chromium change: https://source.chromium.org/chromium/chromium/src/+/dbb5f699d914e0eb5a8ce1315484c73f81ab0b9b commit dbb5f699d914e0eb5a8ce1315484c73f81ab0b9b Author: Robert Sesek <rsesek@chromium.org> Date: Thu Aug 12 19:40:28 2021 +0000 Delete content::WebContentsReceiverSet. All callers have been migrated to its replacement, RenderFrameHostReceiverSet. Bug: 1213679

blink::HeapObjectHeader, blink::TraceDescriptor and blink::TraceTrait are not being used at all in our override of execution_context.h, which is now breaking the build due to missing includes, so let's remove the using statements from there.

Better use size_t for the type of the indexes instead of int.

Chromium change: https://source.chromium.org/chromium/chromium/src/+/5510e6db4216bdc0b911021b1c6e924f6fe655a4 commit 5510e6db4216bdc0b911021b1c6e924f6fe655a4 Author: Nancy Wang <nancylingwang@chromium.org> Date: Thu Aug 12 18:17:42 2021 +0000 Open the browser with the crash bubble after reboot from crash. When the full restore feature is enabled, if the system startsup from crash, the full restore notification is shown. If the user doesn't response the full restore notification, but launch the browser, the browser session can't be restored because 'HasPendingUncleanExit': https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/sessions/session_service.cc;l=104. This CL modified the session service to show the crash bubble for the first time open the browser, if the user doesn't response the full restore notification: 1. If the browser is null, call StartupBrowserCreator to create a new browser instance. 2. If the browser is not null, show the crash bubble in the current browser instance. BUG=1146900

Chromium change: https://source.chromium.org/chromium/chromium/src/+/b48eecf01d5df4e493adff8d4ba1b3847c4d0d2d commit b48eecf01d5df4e493adff8d4ba1b3847c4d0d2d Author: Anthony Cui <cuianthony@google.com> Date: Tue Aug 10 00:43:54 2021 +0000 Rename translate site-blocklist related methods Bug: 1234106

This has been newly added upstream and needs to be added, otherwise we will get a linking failure. Chromium change: https://source.chromium.org/chromium/chromium/src/+/62f94bd5adf55b3a7eae0c7a14fcf957a3c79d7d commit 62f94bd5adf55b3a7eae0c7a14fcf957a3c79d7d Author: Will Harris <wfh@chromium.org> Date: Wed Aug 11 16:48:40 2021 +0000 Change transport_security_persister_path param to be a path to a file. This CL changes transport_security_persister_path parameter in the NetworkContextParams to be a full file path rather than a path to a folder that contains a fixed file called "TransportSecurity". This is to support the network sandbox as ACLs need to be set on these files, so the full path must be known by the content layer rather than being only known by net layer. This CL contains no functional changes and, in particular, does not change the path of the transport security persistent data. However, this CL intentionally changes the name of the parameter in the network context parameters and the order of the constructor parameters to ensure all callers update their code to pass a full file path rather than a path to a directory. BUG=1173622

Chromium change: chromium/chromium@abc5c8d [Android][Signin] Merge SigninStateObserver and SigninAllowedObserver… … into one This CL refactors the SigninManager observers by merging SigninStateObserver and SigninAllowedObserver into one. Bug: 1152333

….4606.20.

Chromium change: https://source.chromium.org/chromium/chromium/src/+/b28ad553ae6420e0075aa2d1815b4746559b70ed commit b28ad553ae6420e0075aa2d1815b4746559b70ed Author: Lei Zhang <thestig@chromium.org> Date: Tue Jul 27 23:57:50 2021 +0000 Fix base::NoDestructor usage in Mac KeychainPassword. Reduce the scope of the base::NoDestructor instances to avoid creating static initializers.

Chromium change: https://chromium.googlesource.com/chromium/src.git/+/1a48a0d1aa11b8cc6aad740c2682677311d0d6d5 commit 1a48a0d1aa11b8cc6aad740c2682677311d0d6d5 Author: Jesse McKenna <jessemckenna@google.com> Date: Wed Jul 28 18:46:51 2021 +0000 breadcrumbs: migrate ApplicationBreadcrumbsLogger This change migrates ApplicationBreadcrumbsLogger to the new breadcrumbs component as part of making breadcrumbs work on desktop. An iOS-specific derived class, ApplicationBreadcrumbsLoggerIOS, handles orientation breadcrumbs, which are only logged on iOS. This also removes crash-report helper functions MonitorBreadcrumbManager() and StopMonitoringBreadcrumbManager(), as their only callers are removed in this change. Bug: 1163762

Chromium change: https://source.chromium.org/chromium/chromium/src/+/76c71475e86b8eeaabcd397c15e4919c83605e67 commit 76c71475e86b8eeaabcd397c15e4919c83605e67 Author: Justin Cohen <justincohen@google.com> Date: Tue Jul 27 02:05:57 2021 +0000 ios: Merge iOS's clean exit beacon implementation with CleanExitBeacon. Previous experiments show there is a large mismatch between using local state for the clean exit beacon vs using NSUserDefaults. It seems that the macOS defaults system is more reliable. See bug for more details. Merges the iOS implementation of using defaults to track clean exit with the CleanExitBeacon, and migrates the CleanExitBeaconConsistency histogram to use kStabilityExitedCleanly. This deprecates the iOS specific kLastSessionExitedCleanly, which is now unused. Also adds a feature flag to compare using defaults vs local state for tracking a clean exit. Bug: 1231106

…and. Chromium change: https://source.chromium.org/chromium/chromium/src/+/c9e96cf2b38596eb1143ed5fe0e45ae697aded1b commit c9e96cf2b38596eb1143ed5fe0e45ae697aded1b Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Aug 5 12:21:39 2021 +0000 Reland "[ios] Use the new `app_distribution` API in //ios/chrome/browser" This is a reland of e00024ecb77f45b2aa70ef0b87c6ca2ab0116eab This add necessary changes to //ios/chrome/browser/rlz that were lacking in the original CL (as the file are only build when `is_chrome_branded` is `true`). Original change's description: > [ios] Use the new `app_distribution` API in //ios/chrome/browser > > Use the `app_distribution` API exposed as free function instead of the > old API going through the `AppDistributionProvider` class. > > The class `AppDistributionProvider` is not removed yet to prevent > breaking the internal repository when this CL lands. It will be > removed in a followup CL once the override has been deleted. > > Add free functions to the test implementation of `app_distribution` API > to check whether the app distribution notifications have been scheduled > or canceled. > > Bug: 1201182

Chromium change: https://source.chromium.org/chromium/chromium/src/+/a482736f658267fab9015a432aa2368870813704 commit a482736f658267fab9015a432aa2368870813704 Author: Xiaohan Wang <xhwang@chromium.org> Date: Fri Jul 23 04:46:37 2021 +0000 [CodeHealth] Remove OnRendererProcessCrash() This is not called in the code base, so remove it.

We build with `ios_enable_credential_provider_extension = false` but the recent upstream change causes errors in this configuration: Initially: ERROR Unresolved dependencies. //ios/chrome/app:credential_provider_migrator_app_agent(//build/toolchain/ios:ios_clang_x64) needs //ios/chrome/browser/credential_provider:credential_provider(//build/toolchain/ios:ios_clang_x64) And, also: ../../ios/chrome/app/main_controller.mm:663:29: error: use of undeclared identifier 'CredentialProviderAppAgent' [self.appState addAgent:[[CredentialProviderAppAgent alloc] init]]; ^ 1 error generated. Filed an upstream bug with this info: https://bugs.chromium.org/p/chromium/issues/detail?id=1245295 Chromium change that caused the issue: https://chromium.googlesource.com/chromium/src.git/+/b32f389ea82506054ab7fda2ce6abbabe0c2a797 commit b32f389ea82506054ab7fda2ce6abbabe0c2a797 Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Tue Aug 10 18:41:12 2021 +0000 [iOS][Credential-Provider] Import CPE passwords to password manager Move Credential Provider Extension (CPE) passwords from temporal storage to password manager. CPE stores the password in the Keychain already, so there is no need to re-encrypt passwords. Bug: 1224983 Chromium upstream fixes applied as patches (not available in cr94 yet): https://chromium.googlesource.com/chromium/src.git/+/ab3809244ea889dd3232708c700893e230a559ea commit ab3809244ea889dd3232708c700893e230a559ea Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Aug 23 15:03:06 2021 +0000 [ios] Fix build when credential provider is disabled Change //ios/chrome/app:credential_provider_migrator_app_agent target to only be build when ios_enable_credential_provider_extension (as it depends on //ios/chrome/browser/credential_providers that isn't build if ios_enable_credential_provider_extension is false). Bug: none https://chromium.googlesource.com/chromium/src.git/+/712ab90025a19b49b18f1d3d40ed2143d6149ca5 commit 712ab90025a19b49b18f1d3d40ed2143d6149ca5 Author: Javier Ernesto Flores Robles <javierrobles@chromium.org> Date: Wed Sep 8 18:48:59 2021 +0000 [iOS][Credential-Provider] Guard CredentialProviderAppAgent Bug: 1245295

…s.py fixes brave/brave-browser#17809 Related Chromium change https://source.chromium.org/chromium/chromium/src/+/0470f485e51e6ebb07cb96a64fd077fb3e5ff9ee : build: remove is_python2.py _is_python2 is always false now. Bug: 1112471 Change-Id: I049610e59c7f51472b6326a7fcdd82c732725cec

Upstream fully transitioned now to helper (Alerts) and removed XPC notification service. We should no longer mess with the identifier for that executable. See original change: #8755 See upstream: https://bugs.chromium.org/p/chromium/issues/detail?id=1170731

….4606.31.

Roll back some of the changes done in the prior commit with the same title (minus II) due to a revert upstream. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/54772f307e724 commit 54772f307e724e8d2cb00a443027e9e0c1be202d Author: Ali Beyad <abeyad@chromium.org> Date: Tue Aug 31 15:27:44 2021 +0000 Merge to M94 branch: Revert "Add Sec-CH-UA-Reduced client hint header when Origin Trial token present" This reverts commit 7417fc2bd5c8cf0e6dbf7ca4b599603c67d3edf3 (CL on Gerrit: https://chromium-review.googlesource.com/c/chromium/src/+/3064532). This revert is only applied on the M94 branch. The reason for the revert is that the User-Agent Reduction Origin Trial was only partially implemented by the time the M94 branch was cut. We want to revert the Origin Trial changes because we don't want a user on M94 visiting a site that is participating in the Origin Trial to get a half-baked or undefined implementation behavior. For this change being reverted, we would've ended up sending Sec-CH-UA-Reduced without sending a reduced User-Agent string in the request header. Chrome feature: https://chromestatus.com/feature/5704553745874944 Bug: 1245043

This was initially needed as per some changes that were going to be added as part of PR #8124[1] (in commit 8ba9ddb[2]), that used util::WallClockTimer, but the merged PR ended up implementing things differently and this dependency was left around in the BUILD.gn file. Since //base/util/timer does not exist anymore in Chromium 94 (i.e it has been moved to //base/timer), this is breaking the build now so let's remove the stray dependency. [1] #8124 [2] 8ba9ddb5

This was added as part of PR #8124[1] (in commit 1ab371c[2]) but then removed lated in the same PR before merging (commit be1073b[3]), leaving the include around without being needed, so let's drop it. [1] #8124 [2] 1ab371c4 [3] be1073be

Chromium change: https://source.chromium.org/chromium/chromium/src/+/f60c8d2b2478e42fe420cb5012e304d72f1f2613 commit f60c8d2b2478e42fe420cb5012e304d72f1f2613 Author: Albert J. Wong <ajwong@chromium.org> Date: Tue Jul 27 07:25:26 2021 +0000 Merge //base/util/values into //base/json This is part of merging all of //base/util back into //base. Bug: 1227210

Even though //tools/gritsettings/resource_ids.spec claims that ids of 31000+ are reserved for project built on top of Chromium, their own ids no longer stay under that number. I was getting a DCHECK of collision of our ids in brave_components_resources.pak with Chromium's resources.pak. Shifted our IDs to start from 38000.

Uncaught SyntaxError: The requested module '../appearance_page/appearance_browser_proxy.js' does not provide an export named 'AppearanceBrowserProxy'

Upstream added another element with `if=...pageVisibility.privacy` attribute so our getSectionElement function ended up picking the wrong one. Adjusted the function to prefer `if=[[showPage_(...` attribute over other conditionals. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/6ad96baa commit 6ad96baaf19c658abd8ccacf24ec27485337046c Author: Bret Sepulveda <bsep@chromium.org> Date: Mon Aug 9 16:15:40 2021 +0000 Privacy Review: promo card element This patch adds the promo card polymer element with the correct styling and a button that begins the review flow when clicked. As of this patch, the promo is always shown when the flag is enabled. Bug: 1215630

…iders.

….4606.41.

This reverts commit 0b78f9e, reversing changes made to d260b6a. Reverting because upstream has fixed the first run regression via: https://chromium.googlesource.com/chromium/src.git/+/f9385e0d893916cbb16b477bdec127e56f9897da Cherry-picked into cr94 as https://chromium.googlesource.com/chromium/src/+/3f20e2edeb0adf78a6a9a6208e2e02ad3c7d8810 commit f9385e0d893916cbb16b477bdec127e56f9897da Author: Caitlin Fischer <caitlinfischer@google.com> Date: Mon Aug 30 13:31:02 2021 +0000 Ignore Local State when deciding whether to show the first run dialog. The bug was caused by an experiment that causes Local State to be written to disk during startup (before the first-run-dialog-showing logic is reached) on some clients. Since Local State existed on some clients, the dialog was not shown. However, the first-run-dialog-showing logic should not depend on the presence or absence of a Local State file. This change affects some POSIX platforms running Google Chrome for the first time. This logic being removed was originally added here: https://chromiumcodereview.appspot.com/14946003/. Bug: 1221483

Seems to be only causing a problem on MacOS. On other platforms rollup finds our files, but on MacOS it doesn't: [!] Error: Could not resolve './brave_overrides/index.js' from gen/chrome/browser/resources/settings/tsc/settings.js Upstream is picking up files from tsc folder now for rollup, so it seems that's where we should drop ours. Chromium change: https://source.chromium.org/chromium/chromium/src/+/36d4bff7cb074ec08a3097f0b05eb375bfd04087 Author: dpapad <dpapad@chromium.org> Date: Fri Jul 30 09:23:37 2021 +0000 Settings: Migrate to TypeScript compiler, still using JS. Bug: 1234307

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade from Chromium 93 to Chromium 94. #9558

Upgrade from Chromium 93 to Chromium 94. #9558

Commits on Sep 13, 2021