Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Middle click is not working on Home button #9562

Closed
NejcZdovc opened this issue Jun 19, 2017 · 6 comments
Closed

Middle click is not working on Home button #9562

NejcZdovc opened this issue Jun 19, 2017 · 6 comments

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 19, 2017

Test plan

See #9672 (comment)

Original issue description

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    Middle click is not working on Home button. This regressed when we needed introduce aux event for chromium 54.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version (revision SHA):
    fab48e2

  • Steps to reproduce:

    1. Middle click on Home button
  • Actual result:
    Nothing happens

  • Expected result:
    Tab with home page is opened in a new tab

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    yes

  • Is this an issue in the currently released version?
    yes

  • Can this issue be consistently reproduced?
    yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@NejcZdovc NejcZdovc added this to the 0.19.x (Nightly Channel) milestone Jun 19, 2017
@NejcZdovc NejcZdovc self-assigned this Jun 19, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 19, 2017
Resolves brave#9562

Auditors: @bsclifton

Test Plan:
- middle click on Home button
- new tab is opened
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 19, 2017
Resolves brave#9562

Auditors: @bsclifton

Test Plan:
- middle click on Home button
- new tab is opened
@NejcZdovc NejcZdovc modified the milestones: 0.17.x (Beta Channel), 0.19.x (Nightly Channel) Jun 19, 2017
bsclifton added a commit that referenced this issue Jun 19, 2017
Fixes middle click not working for  home button
bsclifton added a commit that referenced this issue Jun 19, 2017
Fixes middle click not working for  home button
bsclifton added a commit that referenced this issue Jun 19, 2017
Fixes middle click not working for  home button
@LaurenWags
Copy link
Member

LaurenWags commented Jun 22, 2017

Still seeing the issue as reported on 0.17.6.

@NejcZdovc
Copy link
Contributor Author

Which OS?

@LaurenWags
Copy link
Member

sorry, left that important detail out. MacOS 10.12.5.

@srirambv
Copy link
Collaborator

@NejcZdovc I am not able to middle click on the home button on clean install. But it did work on the upgrade from 0.17.4

@srirambv
Copy link
Collaborator

Need to double check on Linux as it fails on Windows and macOS, hence removing the tag

@NejcZdovc
Copy link
Contributor Author

Yeah sometimes it's working, sometimes is not, will check out what is going on.

@NejcZdovc NejcZdovc reopened this Jun 22, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jun 22, 2017
Resolves brave#9562
Resolves brave#9665

Auditors: @bsclifton

Test Plan:
- try to right click on the home button
- try middle clicking on the home button with title mode ON and OFF
bsclifton added a commit that referenced this issue Jun 23, 2017
Fixes middle and right click for home button
bsclifton added a commit that referenced this issue Jun 23, 2017
Fixes middle and right click for home button
bsclifton added a commit that referenced this issue Jun 23, 2017
Fixes middle and right click for home button
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.